Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Use list of ints for manacc instead of comma-separated string #598

Merged
merged 3 commits into from
Sep 18, 2020
Merged

[ENH] Use list of ints for manacc instead of comma-separated string #598

merged 3 commits into from
Sep 18, 2020

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 21, 2020

Closes #563.

Changes proposed in this pull request:

  • Switch manacc from comma-delimited string to list of integers.
  • Update affected integration test.

@tsalo tsalo changed the title [ENH] Use list of integers for manacc instead of comma-separated string [ENH] Use list of ints for manacc instead of comma-separated string Aug 21, 2020
jbteves
jbteves previously approved these changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tsalo !

@tsalo tsalo requested a review from jbteves August 21, 2020 17:42
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #598 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          26       26           
  Lines        1965     1965           
=======================================
  Hits         1838     1838           
  Misses        127      127
Impacted Files Coverage Δ
tedana/workflows/tedana.py 90.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bdda8...43796ee. Read the comment docs.

@tsalo tsalo mentioned this pull request Sep 18, 2020
Closed
@tsalo tsalo requested a review from emdupre September 18, 2020 20:14
emdupre
emdupre approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks ! Will follow-up on #606 :)

@tsalo tsalo merged commit 3374356 into ME-ICA:master Sep 18, 2020
@tsalo tsalo deleted the enh/manual-selection branch September 18, 2020 20:19
@jbteves jbteves mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbteves jbteves jbteves approved these changes

@emdupre emdupre emdupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace comma-separation in --manacc with space-separation
3 participants
@tsalo @emdupre @jbteves