Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace comma-separation in --manacc with space-separation #563

Closed
tsalo opened this issue Apr 30, 2020 · 3 comments · Fixed by #598
Closed

Replace comma-separation in --manacc with space-separation #563

tsalo opened this issue Apr 30, 2020 · 3 comments · Fixed by #598
Labels
discussion issues that still need to be discussed good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. refactoring issues proposing/requesting changes to the code which do not impact behavior

Comments

@tsalo
Copy link
Member

tsalo commented Apr 30, 2020

Summary

In most cases where we allow multiple inputs for a given argument (e.g., -d, -e, and --gscontrol), tedana accepts a space-separated list at the command line. This should simplify how manacc is handled internally, since the tools already exist to parse nargs='+', and I feel like space-separated parameters are more intuitive at the command line.

Next Steps

  1. Set nargs for --manacc to '+'.
  2. Set type for --manacc to int.
  3. Remove string parsing for manacc within tedana_workflow.
  4. Update documentation.
  5. Update any tests that use manacc.

Discussion

Emoji vote below: 👍 for yes and 👎 for no.

@tsalo tsalo added good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. refactoring issues proposing/requesting changes to the code which do not impact behavior discussion issues that still need to be discussed labels Apr 30, 2020
@emdupre
Copy link
Member

emdupre commented Aug 6, 2020

When do you want to close the voting on this, @tsalo ? 😸

@tsalo
Copy link
Member Author

tsalo commented Aug 6, 2020

Next Friday maybe? August 14.

@tsalo
Copy link
Member Author

tsalo commented Aug 21, 2020

Voting is closed. +2, -0. We're doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion issues that still need to be discussed good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. refactoring issues proposing/requesting changes to the code which do not impact behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants