Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix authors & changelog #4361

Merged
merged 5 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Chronological list of authors
- Lukas Stelzl
- Jinju Lu
- Joshua L. Phillips
- David van der Spoel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a good chance that I set @dspoel as the author of commit 54ed4b3 because these were patches taken directly from git://git.gromacs.org/libxdrfile.git (see commit message) and IIRC they were authored by him.

2013
- Zhuyi Xue
- Xavier Deupi
Expand Down Expand Up @@ -98,6 +99,7 @@ Chronological list of authors
- Micaela Matta
- Jose Borreguero
- Sören von Bülow
- Brigitta Sipőcz
2018
- Nabarun Pal
- Mateusz Bieniek
Expand All @@ -124,6 +126,7 @@ Chronological list of authors
- Lily Wang
- Matthijs Tadema
- Joao Miguel Correia Teixeira
- Michael Gecht
2020
- Charlie Cook
- Yuanyu Chang
Expand Down
4 changes: 2 additions & 2 deletions package/CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Changes
Deprecations


08/15/23 IAlibay, jaclark5, MohitKumar020291, orionarcher, xhgchen,
15/08/23 IAlibay, jaclark5, MohitKumar020291, orionarcher, xhgchen,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a legal MM/DD/YY — I think this needs to be reversed to 08/15/23.

(Sorry that we used US convention... should have used ISO YYYY-MM-DD)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I think I messed up and changed the date in the wrong place sorry! Should have been line 79 🤦🏽‍♂️ teaches me to not pay attention.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, I based my review on the date above this one, which is 28/08/23. Are there problems in multiple locations then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerjereddy it's the one above that is wrong (that's what I was meaning to fix 😅 and changed the wrong one because I was in a rush) - so yes now there are two wrong dates... (sorry)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, I guess Irfan did the same thing maybe, most are the other format.

ztimol, orbeckst

* 2.6.0
Expand Down Expand Up @@ -1785,7 +1785,7 @@ Changes
04/10/17 kain88-de, fiona-naughton, richardjgowers, tyler.je.reddy, jdetle
euhruska, orbeckst, rbrtdlg, jbarnoud, wouterboomsma, shanmbic,
dotsdl, manuel.nuno.melo, utkbansal, vedantrathore, shobhitagarwal1612,
xiki-tempula, kash1102, vedantrathore
xiki-tempula, kash1102

* 0.16.0

Expand Down
Loading