[WIP] Fix authors & changelog

[IAlibay]

Various fixes as I cross-check through the history of our contributors.

Developers certificate of origin

• I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

---

📚 Documentation preview 📚: https://mdanalysis--4361.org.readthedocs.build/en/4361/

[github-actions]

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37d8fee) 93.37% compared to head (09caaff) 93.37%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff             @@
##           develop    #4361     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22340    23453   +1113     
  Branches      4085     4085             
==========================================
+ Hits         20859    21899   +1040     
- Misses         963     1036     +73     
  Partials       518      518             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hmacdope]

LGTM :)

[tylerjereddy]

I think it is "ok" to put the small doc improvements in, CI is happy + core dev approval. I guess there's a WIP in the title, but can always open another if you find more.

[IAlibay]

I should have made this into a draft.. this was still WIP 😅

[IAlibay]

for context in why it was WIP - @orbeckst wasn't sure if we should be adding authors without asking them first, plus we're reaching far into history

[IAlibay]

@orbeckst do you want to weigh in here if you want to revert this change?

[tylerjereddy]

They're already in the git history, if they wanted to be anonymous it is a bit late for that.

[IAlibay]

It's a bit late on my end, but iirc one of Oliver's concerns is that he thinks he might have been the one to add at least one of them (i.e. by tagging them in on a commit). Not really sure I can accurately recollect that discussions - it's probably ok.

[tylerjereddy]

Ok, let's ask them if they mind being listed as authors in MDAnalysis logs: cc @dspoel @bsipocz @mimischi

I'll purge them out if they don't want to be listed, the rest of the changes are valid fixes I think. Defaulting to giving credit if you scrape the author list makes sense to me at least. Adding names to published papers is another matter I suppose, but that's different.

[IAlibay]

Thanks @tylerjereddy 🙏

[orbeckst]

That's not a legal MM/DD/YY — I think this needs to be reversed to 08/15/23.

(Sorry that we used US convention... should have used ISO YYYY-MM-DD)

[IAlibay]

Ahhh I think I messed up and changed the date in the wrong place sorry! Should have been line 79 🤦🏽‍♂️ teaches me to not pay attention.

[tylerjereddy]

I'm confused, I based my review on the date above this one, which is 28/08/23. Are there problems in multiple locations then?

[IAlibay]

@tylerjereddy it's the one above that is wrong (that's what I was meaning to fix 😅 and changed the wrong one because I was in a rush) - so yes now there are two wrong dates... (sorry)

[tylerjereddy]

Ah, I see, I guess Irfan did the same thing maybe, most are the other format.

[orbeckst]

There's a good chance that I set @dspoel as the author of commit 54ed4b3 because these were patches taken directly from git://git.gromacs.org/libxdrfile.git (see commit message) and IIRC they were authored by him.