-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed variable asel
#4077
Renamed variable asel
#4077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS
as part of this PR.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4077 +/- ##
===========================================
- Coverage 93.52% 93.33% -0.19%
===========================================
Files 190 191 +1
Lines 25028 25065 +37
Branches 3542 4042 +500
===========================================
- Hits 23407 23395 -12
- Misses 1100 1145 +45
- Partials 521 525 +4
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@MDAnalysis/coredevs what is the go here? I assume we may need to deprecate first? |
Yeah, as discussed in the original issue, we can't remove this until 3.0, so we need to deprecate the keyword for now, allow both options, and then remove in 3.0. |
@HunterZ17 do you plan on working on this in the near future? If not might be best to close. |
Closing due to lack of activity. |
Fixes #3911
Changes made in this Pull Request:
asel
toag_select
PR Checklist
📚 Documentation preview 📚: https://readthedocs-preview--4077.org.readthedocs.build/en/4077/