Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better workaround to prevent Che-in-Che #47

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Better workaround to prevent Che-in-Che #47

merged 1 commit into from
Jun 21, 2023

Conversation

gchang
Copy link
Contributor

@gchang gchang commented Jun 9, 2023

See MAAP-Project/Community#733 for explanation

@gchang gchang requested review from anilnatha and grallewellyn June 9, 2023 05:06
anilnatha
anilnatha approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@anilnatha anilnatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing what was explained in the associated ticket, this resolution look good to me.

@grallewellyn
Copy link
Contributor

Built the pipeline here: https://repo.dit.maap-project.org/root/maap-workspaces/-/pipelines/2697

And testing the vanilla image in DIT works for me (vanilla is the base image that was giving the nested eclipse che error for me before)

Note that I had 9 other workspaces running while testing this

@gchang gchang merged commit d8e26a8 into develop Jun 21, 2023
anilnatha added a commit that referenced this pull request Jun 22, 2023
@anilnatha
Merge branch 'develop' into features/add-che-sidebar-extension
89074b3 
* develop:
  Fix OpenSSL issue with ISCE3 (#52)
  updated jupyter-server-ext version (#51)
  Better workaround to prevent Che-in-Che (#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grallewellyn grallewellyn grallewellyn approved these changes

@anilnatha anilnatha anilnatha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gchang @grallewellyn @anilnatha