Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace URL prefix generation failing, causes Che-in-Che #733

Closed
gchang opened this issue Jun 8, 2023 · 1 comment
Closed

Workspace URL prefix generation failing, causes Che-in-Che #733

gchang opened this issue Jun 8, 2023 · 1 comment
Assignees
Milestone

Comments

@gchang
Copy link
Collaborator

gchang commented Jun 8, 2023

No description provided.

@gchang gchang self-assigned this Jun 8, 2023
@gchang
Copy link
Collaborator Author

gchang commented Jun 9, 2023

The issue is this code block here: https://github.com/MAAP-Project/maap-workspaces/blob/e2302d9c5b9675a35772418c5cac6b74a570936d/jupyterlab3/entrypoint.sh#L3-L62

At the high level, what it's doing is trying to get the URL that will serve up the jupyter interface. It's in the form of https://blahblahblah/serverdbq97vva-ws-jupyter/server-3100. It's calling the Kubernetes API from inside the pod to get the strings serverdbq97vva and the port 3100. The problem seems to be on occasion -- maybe it's many workspaces running, or having concurrent workspaces starting up -- the Kubernetes API fails to return a value. That's why there's a retry loop in there, current set to 20 retries.

However, there isn't a sleep there, so if it fails, it cycles through the 20 iterations really quickly and then proceeds without the correct URL prefix. As such, then it loads the root page, which is Che itself.

I don't believe there's a way to "refresh" the Kubernetes API to ensure that it returns a value, so the only way is to wait longer. The proposed fix will have a sleep in there to give it some delay as well as increase the iterations.

gchang added a commit to MAAP-Project/maap-workspaces that referenced this issue Jun 9, 2023
gchang added a commit to MAAP-Project/maap-workspaces that referenced this issue Jun 21, 2023
@gchang gchang closed this as completed Jul 6, 2023
@rtapella rtapella modified the milestones: 3.1.1, 3.1.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants