build: Fix libcaesium lookup on Linux #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure looks unrelated. |
|
Re-runned the CI as the previous was a temporary error, but seems is failing to link the library |
`find_library` now needs either `caesium` or `libcaesium.so` to be able to find it. Also link the result with `target_link_libraries` since `find_library` does not register dependencies. https://cmake.org/cmake/help/latest/command/find_library.html https://cmake.org/cmake/help/latest/variable/CMAKE_FIND_LIBRARY_PREFIXES.html This is a follow up to 63761ac
|
Hmm, looks like |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_librarynow needs eithercaesiumorlibcaesium.soto be able to find it.Also link the result with
target_link_librariessincefind_librarydoes not register dependencies.https://cmake.org/cmake/help/latest/command/find_library.html
https://cmake.org/cmake/help/latest/variable/CMAKE_FIND_LIBRARY_PREFIXES.html
This is a follow up to 63761ac