Skip to content

Commit

Permalink
build: Remove redundant linking of libcaesium
Browse files Browse the repository at this point in the history
This is already done by `add_dependencies`
  • Loading branch information
jtojnar committed Feb 17, 2024
1 parent 08a500a commit d5f7a64
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ else ()
LOG_BUILD ON
BUILD_BYPRODUCTS ${LIBCAESIUM_EXTERNAL_PATH}
)
add_dependencies(caesium_image_compressor libcaesium)
add_dependencies(${TARGET} libcaesium)
endif ()

# --- WinSparkle ---
Expand Down Expand Up @@ -249,7 +249,7 @@ elseif (WIN32)
target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql winsparkle ${LIBCAESIUM_SOURCE_DIR}/target/x86_64-pc-windows-gnu/${LIBCAESIUM_BUILD_TYPE}/caesium.dll)
else ()
set_target_properties(${TARGET} PROPERTIES OUTPUT_NAME "caesium-image-compressor")
target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql caesium)
target_link_libraries(${TARGET} PRIVATE Qt${QT_VERSION_MAJOR}::Widgets Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Gui Qt${QT_VERSION_MAJOR}::Concurrent Qt${QT_VERSION_MAJOR}::Svg Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::Sql)
endif ()

add_subdirectory(tests)
Expand Down

0 comments on commit d5f7a64

Please sign in to comment.