-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding backend setting to disable display of GPS direction on map #887
Conversation
Ah, I see the CI failures. Will address shortly. |
Looks like things are good other than the code coverage. I don't see a spot in the existing tests where it would be obvious to plug in, though... how important is this? (Squashed commits.) |
Meh, not much to be honest. We need to refine our testing suite to have more depth and also take care of checking regressions. See #634
That was not necessary, we always do Squash-merge. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the confidentiality, looks good.
database/migrations/2021_01_27_085903_config_map_display_direction.php
Outdated
Show resolved
Hide resolved
Test coverage is a constant uphill battle. Glad to see you all are tackling it, though!
Ah, good to know. I've formed the habit from other repos I contribute to where they prefer the PR to do the squashing. :) |
Kudos, SonarCloud Quality Gate passed! |
@sjml For your next PR, Please create a new branch rather than working on your master. :) That makes it easier for use to interact with your work as we just need to do: git remote add sjml [email protected]:sjml/Lychee
git fetch sjml
git checkout branch-name-you-chose
#modify stuff
git add -u
git commit -m "modified"
git push sjml branch-name-you-chose instead of git remote add sjml [email protected]:sjml/Lychee
git fetch sjml
git checkout sjml/master
git checkout -b sjml/master
#modify stuff
git add -u
git commit -m "modified"
git push sjml sjml-master:master # this here is harder to remember compared to the block above :) The reason the push syntax is different is because of the name conflict between your master branch and our master branch. |
Aye, cap'n! |
This is the backend PR for issue #886. Adds a new configuration setting to control whether the embedded maps use the GPS direction data to display a facing cone. It's set to
true
by default so upgrades won't cause unexpected breaks to existing behavior.(Paired with LycheeOrg/Lychee-front#243)