adding backend setting to disable display of GPS direction on map

[sjml]

This is the backend PR for issue #886. Adds a new configuration setting to control whether the embedded maps use the GPS direction data to display a facing cone. It's set to true by default so upgrades won't cause unexpected breaks to existing behavior.

(Paired with LycheeOrg/Lychee-front#243)

[codecov]

Codecov Report

Merging #887 (8a1d26c) into master (ae6bf41) will decrease coverage by 1.62%.
The diff coverage is n/a.

[sjml]

Ah, I see the CI failures. Will address shortly.

[sjml]

Looks like things are good other than the code coverage. I don't see a spot in the existing tests where it would be obvious to plug in, though... how important is this?

(Squashed commits.)

[ildyria]

Looks like things are good other than the code coverage. I don't see a spot in the existing tests where it would be obvious to plug in, though... how important is this?

Meh, not much to be honest. We need to refine our testing suite to have more depth and also take care of checking regressions. See #634

(Squashed commits.)

That was not necessary, we always do Squash-merge. :)

[ildyria]

Aside from the confidentiality, looks good.

[sjml]

Meh, not much to be honest. We need to refine our testing suite to have more depth and also take care of checking regressions. See #634

Test coverage is a constant uphill battle. Glad to see you all are tackling it, though!

[Squashing commits] was not necessary, we always do Squash-merge. :)

Ah, good to know. I've formed the habit from other repos I contribute to where they prefer the PR to do the squashing. :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ildyria]

@sjml For your next PR, Please create a new branch rather than working on your master. :)
https://lycheeorg.github.io/docs/contributions.html#which-branch-to-use

That makes it easier for use to interact with your work as we just need to do:

git remote add sjml [email protected]:sjml/Lychee
git fetch sjml
git checkout branch-name-you-chose
#modify stuff
git add -u
git commit -m "modified"
git push sjml branch-name-you-chose

instead of

git remote add sjml [email protected]:sjml/Lychee
git fetch sjml
git checkout sjml/master
git checkout -b sjml/master
#modify stuff
git add -u
git commit -m "modified"
git push sjml sjml-master:master  # this here is harder to remember compared to the block above :)

The reason the push syntax is different is because of the name conflict between your master branch and our master branch.

[sjml]

For your next PR, Please create a new branch rather than working on your master

Aye, cap'n!