Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Disable direction display (more general: ignore certain EXIF tags) #886

Closed
sjml opened this issue Jan 27, 2021 · 2 comments
Closed
Labels
enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted

Comments

@sjml
Copy link
Contributor

sjml commented Jan 27, 2021

I'm setting up a new gallery with a lot of images that are geotagged. What I'm discovering, though, is that while the GPS locations are accurate, the direction info usually is not. On top of that, the apps that I use tend to only expose correction of the latitude/longitude, not of the direction, so it's a difficult problem to fix for large numbers of photos.

I'd be happy for the photo's map to simply not show the direction, but I don't see any simple way to disable it beyond hacking the JavaScript myself (which would not survive an upgrade).

Would you accept a PR to expose something like "Ignore GPS direction" as a setting?

Alternately, and maybe solving a more general problem: is there some way to create an exclusion list of EXIF tags so that the import process could treat the photo as if it does not have those tags?

EDIT: I have a PR ready to go that does the simpler version of this (just adding a config flag to not use the direction data in the embedded map), but not sure how you prefer to handle it since it's properly two PRs, one to this repo and another to Lychee-front. Let me know!

@ildyria
Copy link
Member

ildyria commented Jan 27, 2021

Would you accept a PR to expose something like "Ignore GPS direction" as a setting?

I have nothing against such setting. :)

Alternately, and maybe solving a more general problem: is there some way to create an exclusion list of EXIF tags so that the import process could treat the photo as if it does not have those tags?

This is an interesting alternative, though the implementation of such thing would be interesting.

I have a PR ready to go that does the simpler version of this (just adding a config flag to not use the direction data in the embedded map), but not sure how you prefer to handle it since it's properly two PRs, one to this repo and another to Lychee-front. Let me know!

Usually the process is as follows:

  • we take the 2 PR (Lychee-front and Lychee),
  • review them both,
  • merge on Lychee-front
  • switch Lychee-front to master, rebuild & commit on the PR.
  • merge to Lychee master

@ildyria ildyria added enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted labels Jan 27, 2021
@sjml
Copy link
Contributor Author

sjml commented Jan 27, 2021

Great, I'll prep two PRs, then. Thanks!

This is an interesting alternative, though the implementation of such thing would be interesting.

(Yeah, I think "interesting" is the right choice of word there. :) While it might be worth doing in the long run, it's definitely beyond the scope of fixing this very simple problem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted
Projects
None yet
Development

No branches or pull requests

2 participants