Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #241: Fix backslash issue composer-lock diff. #579

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Issue #241: Fix backslash issue composer-lock diff. #579

merged 1 commit into from
Jul 11, 2024

Conversation

alexanderpatriciop
Copy link
Collaborator

@alexanderpatriciop alexanderpatriciop linked an issue May 24, 2024 that may be closed by this pull request
Error in composer-lock diff test when PR description contains a backslash "\" before open bracket “[“, open parenthesis “(“ or underscore "_". #241
Closed
@github-actions github-actions bot temporarily deployed to pantheon-pr-579 May 24, 2024 18:54 Destroyed
@alexanderpatriciop alexanderpatriciop linked an issue May 24, 2024 that may be closed by this pull request
ComposerLockDiff fails when PR description contains "#\" #257
Closed
mrdavidburns
mrdavidburns approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@mrdavidburns mrdavidburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrdavidburns mrdavidburns merged commit 44b7d45 into main Jul 11, 2024
35 of 36 checks passed
@mrdavidburns mrdavidburns deleted the 241--fix-backslash-issue-composer-lock-diff branch July 11, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdavidburns mrdavidburns mrdavidburns approved these changes

@justafish justafish Awaiting requested review from justafish

@beto-aveiga beto-aveiga Awaiting requested review from beto-aveiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexanderpatriciop @mrdavidburns