Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComposerLockDiff fails when PR description contains "#\" #257

Closed
hawkeyetwolf opened this issue Sep 1, 2023 · 6 comments · Fixed by #579
Closed

ComposerLockDiff fails when PR description contains "#\" #257

hawkeyetwolf opened this issue Sep 1, 2023 · 6 comments · Fixed by #579
Labels
bug Something isn't working client affected

Comments

@hawkeyetwolf
Copy link
Contributor

The ComposerLockDiff GitHub Actions workflow fails on PRs that have "#\" in the PR description.

In my case, I was trying to print "#2" without GitHub automatically linking to the corresponding issue or PR number 2. So I added a slash in front like this: "#\2", and then the ComposerLockDiff workflow began failing. Changing the PR description to <span>#</span>2 made the workflow begin passing again.

This issue is very similar to #181 (closed): Error in composer-lock diff process when PR description contains new lines. The error is the same:

curl: (22) The requested URL returned error: 400
Error: Process completed with exit code 22.

which happens when executing line 52 in the workflow file:

@hawkeyetwolf
Copy link
Contributor Author

cc @deviantintegral

@penyaskito
Copy link
Member

penyaskito commented Oct 10, 2023

I have a similar issue in a client site, but not with #\. In this case I suspect is a code block with an iframe.

@deviantintegral
Copy link
Member

There's also an issue causing it to remove \. See in this diff how \\xd2 became \xd2:

image

@deviantintegral
Copy link
Member

Related: #332 .

@deviantintegral deviantintegral added bug Something isn't working client affected labels Feb 19, 2024
@mrdavidburns
Copy link
Member

Is #318 also related?

@deviantintegral
Copy link
Member

It wouldn't surprise me if it's the same section of code causing the problem, but we won't know until someone dives into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client affected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants