Fix TR1 camera positions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lahm86
commented
Dec 13, 2024
lahm86
commented
- Adds support in TR1 for moving fixed cameras
- Creates injections for Return to Egypt, Temple of the Cat and Natla's Mines
2 tasks
rr-
reviewed
Dec 13, 2024
| X = x == -1 ? camera.X : x, | ||
| Y = y == -1 ? camera.Y : y, | ||
| Z = z == -1 ? camera.Z : z, | ||
| Room = roomNum == -1 ? camera.Room : roomNum, |
There was a problem hiding this comment.
Wouldn't we be better off calling this function SetCameraPosition? Shift sounds like we're dealing with relative offsets. Additionally I think the defaults for the XYZ arguments should be -1.
There was a problem hiding this comment.
You're right, I started off with the idea of doing shifts but it was getting too complicated to track, so easier to set the position fully. Will update.
lahm86
force-pushed
the
tr1-camera-fixes
branch
from
436731f to
741c61d
Compare
rr-
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.