tr1/data: fix various camera positions #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows injections to shift fixed cameras.
This adjusts some cameras in Return to Egypt and Temple of the Cat to resolve LOS issues. Resolves LostArtefacts#1317.
This shifts the camera in Natla's Mines that looks at the boat while it's moving, so to avoid seeing the flip state. Resolves LostArtefacts#2019.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
approved these changes
Dec 13, 2024
aredfan
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1317.
Resolves #2019.
Checklist
Description
This adds workarounds for cameras in Return to Egypt and Temple of the Cat to resolve LOS issues introduced by 4.1 (the issue being the cameras are positioned where walls obstruct their view, but 4.1 removed LOS checks on fixed cameras to resolve many other problems).
The camera in Natla's Mines is also shifted slightly when moving the boat so that you can't see the already flipped state.
This is low priority but I'm aiming to tidy up some injection loose ends before we continue with the overall format refactor.
Ref: LostArtefacts/TRXInjectionTool#18