Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grenade: fix kills counting as two kills #1764

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

walkawayy
Copy link
Collaborator

Resolves #1560.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fix grenades counting as double hits and kills in the game statistics.

@walkawayy walkawayy added OG bug A bug in original game TR2 labels Oct 27, 2024
@walkawayy walkawayy self-assigned this Oct 27, 2024
@walkawayy walkawayy requested review from a team as code owners October 27, 2024 20:42
@walkawayy walkawayy requested review from rr- and lahm86 and removed request for a team October 27, 2024 20:42
Copy link

github-actions bot commented Oct 27, 2024

@walkawayy
Copy link
Collaborator Author

@aredfan I guess double check if the hit count is bugged or not in this PR. Based on your comment in the issue, it seems only the kill count is bugged. I wonder if this PR broke the hit count? Like is it causing grenades to do 1 kill and 0 hits.

@walkawayy walkawayy requested a review from lahm86 October 27, 2024 23:31
@aredfan aredfan self-requested a review October 28, 2024 10:41
Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you. 👍

@walkawayy walkawayy changed the title grenade: fix grenades counting as double hits and kills grenade: fix kills counting as two kills Oct 28, 2024
@walkawayy walkawayy merged commit db9f33b into LostArtefacts:develop Oct 28, 2024
6 checks passed
@walkawayy walkawayy deleted the grenades-extra-kill branch November 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OG bug: killing enemies with grenades count as 2 kills
4 participants