output: improve vertex movement #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows locking specific vertices such that they don't move when looked at through a water portal. We make use of an unused bit in vertex shading, and ensure shading is clamped to the max value. Resolves LostArtefacts#1493.
lahm86
requested review from
rr- and
walkawayy
and removed request for
a team
aredfan
approved these changes
Sep 6, 2024
rr-
approved these changes
Sep 6, 2024
|
I think we can leave it linked with textures. |
walkawayy
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1493.
Checklist
Description
This allows locking specific vertices such that they don't move when looked at through a water portal. We make use of an unused bit in vertex shading, and ensure shading is clamped to the max value.
This only covers vertices on water edges, as mentioned in #1493 there are other situations which would require a big undertaking of work to inject face/vertex/texture changes, and I don't think that it's feasible. This brings things into line with TR2 though, so it's a definite improvement.
I've tied this to the texture fix option in the config, but LMK if you think this deserves its own setting.