Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vertex movement #1493

Closed
lahm86 opened this issue Sep 6, 2024 · 1 comment · Fixed by #1496 or #1663
Closed

Improve vertex movement #1493

lahm86 opened this issue Sep 6, 2024 · 1 comment · Fixed by #1496 or #1663
Assignees
Labels
Enhancement Improvement of an existing feature TR1 TR2

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Sep 6, 2024

When looking through water portals, all vertices in the opposite water status rooms move, which results in gaps where the rooms join. In TR2, room vertices have attributes for controlling this, but TR1 room vertices only have position and shade. Add an initial improvement to this, to target locking vertices that are on room edges.

image

Note that it won't feasibly be possible to fix every situation, as indeed you can see in TR2. This is a level design issue where vertices don't always match up between faces, and so the movement becomes out of sync. Fixing this would mean manually adjusting faces, vertices and tex infos, which is a very big task.

image

@lahm86 lahm86 added the Feature New functionality label Sep 6, 2024
@lahm86 lahm86 added this to the 4.4 milestone Sep 6, 2024
@lahm86 lahm86 self-assigned this Sep 6, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Sep 6, 2024
This allows locking specific vertices such that they don't move when
looked at through a water portal. We make use of an unused bit in
vertex shading, and ensure shading is clamped to the max value.

Resolves LostArtefacts#1493.
@lahm86 lahm86 closed this as completed in 858f13d Sep 6, 2024
@rr- rr- added the TR1 label Oct 3, 2024
@rr-
Copy link
Collaborator

rr- commented Oct 4, 2024

Reopening as we found a technique so that this can be improved even further.

@rr- rr- reopened this Oct 4, 2024
@rr- rr- assigned rr- and unassigned lahm86 Oct 4, 2024
@rr- rr- added Enhancement Improvement of an existing feature and removed Feature New functionality labels Oct 4, 2024
@rr- rr- moved this to In progress in TRX Dev tracker Oct 4, 2024
@rr- rr- removed this from the TR1X-4.4 milestone Oct 4, 2024
@rr- rr- added the TR2 label Oct 4, 2024
rr- added a commit that referenced this issue Oct 4, 2024
rr- added a commit that referenced this issue Oct 4, 2024
rr- added a commit that referenced this issue Oct 4, 2024
Resolves TR1X part of #1493.
@rr- rr- removed the TR1 label Oct 4, 2024
@rr- rr- moved this from In progress to Ready in TRX Dev tracker Oct 4, 2024
@rr- rr- closed this as completed in #1663 Oct 4, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in TRX Dev tracker Oct 4, 2024
@rr- rr- added the TR1 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1 TR2
Projects
Archived in project
2 participants