Clarify wording for Learn More screen in Uncertain Delivery State #104
Conversation
OmniBLE/PumpManagerUI/Views/DeliveryUncertaintyRecoveryView.swift
Outdated
Show resolved
Hide resolved
|
Thanks for the input. Edited to remove graphics on 25 January 2024. |
|
Looks great - the PR on the slider needs to include this Deactivate Pod button too |
|
Can I ask why there needs to be this deactivate pod button here at all. If the pod has lost comm, how do you deactivate it from this menu? |
ps2
changed the title
|
Yes, it should skip the "deactivate" part, and just have a "Forget Pod" button. There does need to be a way to get out of this state, if comms cannot eventually be restored. |
|
Making changes one step at a time. This commit
Edited to remove graphics on 25 January 2024. |
|
I will need guidance if additional modifications are desired to the actions. Right now, the next screen after tapping Discard Pod (on the screen in prior comment) is the Deactivate Pod screen, which, if comms still fail, takes you to the Discard Pod screen as shown in the graphic below.
|
|
See comment when testing similar change for OmniKit: LoopKit/OmniKit#23 (comment) |
|
Updated with the graphics that match the latest commit (25 January 2024). After working with the uncertain comms for OmniKit, I modified those words then came back to this PR and modified them for consistency. Top row - comes from LoopKit and is not modified.
|
| Button(action: { | ||
| self.model.podDeactivationChosen() | ||
| }) { | ||
| Text(LocalizedString("Deactivate Pod", comment: "Button title to deactive pod on uncertain program")) | ||
| Text(LocalizedString("Discard Pod", comment: "Button title to discard pod on uncertain program")) |
There was a problem hiding this comment.
I think this still takes the user to deactivate, rather than discard, but I'm on the fence about which is better.
There was a problem hiding this comment.
Yes it does because I couldn’t figure out how to change it.
But on the other hand, if it succeeds in reaching the pod, the pod gets deactivated so there’s no screamer but at the same time you’re mad because you gave up too soon.
Here's a first cut for modifying the Learn More screen for DASH pods.
The top part of the graphic is what is displayed now.
The bottom part matches the current commit.
For both cases, I had to scroll up to read all the text.
Removed graphic because I updated words based on comments. See later comment for new graphics.