Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slider instead of button to Deactivate Pod #102

Merged

Conversation

marionbarker
Copy link
Collaborator

@marionbarker marionbarker commented Oct 24, 2023

This commit changes the Deactive Pod button to a slider matching the Insert Cannula slider.

The graphic below shows the light and dark versions.

I have this on my own phone and on several test phones. (I have tested using an rPi simulator and will use it for "real" next time I change my pod.)

omnible-deactivate-slide-light-dark

@marionbarker
Copy link
Collaborator Author

I successfully used this modification on my own phone for changing a DASH pod yesterday. (25 Oct 2023).

@marionbarker marionbarker changed the title Insert cannula and deactivate view improvements Use slider instead of button to Deactivate Pod Nov 13, 2023
@marionbarker
Copy link
Collaborator Author

I modified the name to "Use slider instead of button to Deactivate Pod" because the insert cannula PR was merged already.

@marionbarker
Copy link
Collaborator Author

There were comments about using a slider to Deactivate a pod found here:

In summary, several of the people who posted got to the Deactivate Pod screen when they were having communication issues - which is why I added PR #104.

I was not able to find a specific Facebook post describing this scenario, but over the years I have seen several posts that a child or caregiver attempted to enter a treatment and accidentally deactivated the pod.

I believe that seeing a slider instead of a button to tap might have slowed them down enough to not loose a pod.

I have been using this on my "real" phone since October and I can report that every time the slider comes up (for insert and deactivate), it does slow me down and make me think.

@marionbarker
Copy link
Collaborator Author

Please hold on this PR until Loop Issue 2105 is resolved.

@marionbarker
Copy link
Collaborator Author

Updated to latest LoopWorkspace to bring in the updated SlideButton version.
Tested with Hebrew using InsertCannula_Deactivate_ViewImprovements branch for OmniBLE:

  • insert cannula slider worked as expected
  • deactivate cannula slider worked as expected
  • switched to English and repeated test
  • both insert and deactivate worked as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants