Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow high temp when min bg is below target, above min bg guard, and eventual bg is above target. #530

Closed
ps2 opened this issue Jul 27, 2017 · 5 comments
Labels

Comments

@ps2
Copy link
Collaborator

ps2 commented Jul 27, 2017

Currently Loop will restrict basal rates to <= currently scheduled rate in this case.

With min bg guard in place now, this restriction is questionable. Users can specify how low min bg has to be before high temping should be disabled by adjusting min bg guard.

img_6687_png

@francesc0-cgm
Copy link

This is what i asked a couple days ago. I'm totally agree to this modification

@ps2
Copy link
Collaborator Author

ps2 commented Jul 27, 2017

@francesc0-cgm This is how Loop has always been; I believe you were referring to some change in dynamic carbs that you had issues with.

@francesc0-cgm
Copy link

Sorry @ps2 atm when any predicted bg is under the target also if later is over the target and always above min bg guard loop will set neutral temp isn't it?

ps2 added a commit that referenced this issue Nov 28, 2022
ps2 added a commit that referenced this issue Nov 28, 2022
* [LOOP-4205] always display time changed alert when detected. retract when needed (#523)

* Adjust method to match updated protocol (#524)

* [LOOP-4289-4348] Critical alert modal and banner update (#525)

* initial pass at adding go to settings button in the critical alert modal

* remove foreground content from the riskMitigationAlert, since it is handle by the AlertManager

* added placeholder text for the alert premissions disabled banner

* add dismiss button to alert permissions disabled warning

* acknowledge alert with close option

* response to PR comments

* clean up

* more cleanup

* updated notification permissions banner

* updated style of alert permission disabled alert

* copy update

* [LOOP-4348] adjusted layout of notification permissions disabled banner (#527)

* [LOOP-4289] Also issue iOS notification (#528)

* issue notification permission alert when in background and retract in-app alert as needed

* remove unused code

* response to PR comments

* [LOOP-4348] notification permission banner for narrow display (#529)

* Fix crash in ZipArchiveTests (#530)

* [LOOP-4400] made status highlight container for CGM and pump pill the same size (#531)

* [LOOP-4349] Temporary mute alerts (#526)

* added placeholder UI to configure mute alerts duration

* checkpoint

* checkpoint

* initial commit at the alert muter

* minor clean-up

* removed unused file from project

* corrected predicate syntax

* all alerts at least vibrate

* checkpoint

* insteadOf = https://github.com/
updating unit tests

* checkpoint

* tighter coupling between alert manager and in-app/user notification alert issuers

* corrected rescheduling loop not running notifications and use timers for UI

* make the mute end period timer internval to the alert muter

* corrected typo

* updated unit tests

* added duration to temp mute alerts setting

* minor clean-up

* using source of truth for last loop date

* renamed Issuer -> Scheduler for in-app and user notification

* [LOOP-4349] corrected loop not looping rescheduling (#532)

* corrected identifier for loop not looping notifications

* updated test to run for both DIY and Tidepool

* COASTAL-1076 Support PumpManagerUI pausing onboarding (#533)

* Prevent marking onboarding as finished when pausing

* Update comment for clarity

* Use new iOS 16 method to notify VC of supported orientation change update (#534)

* [COASTAL-1124] Time alert copy update (#535)

* updated copy of time alert

* using device model

* Disable mute alerts feature (wip) and fix tests

Co-authored-by: Nathaniel Hamming <[email protected]>
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 24, 2023
Copy link

github-actions bot commented Dec 8, 2023

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants