Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font issue in HUD #523

Closed
jmatheson opened this issue Jul 17, 2017 · 2 comments · Fixed by #584
Closed

Font issue in HUD #523

jmatheson opened this issue Jul 17, 2017 · 2 comments · Fixed by #584

Comments

@jmatheson
Copy link
Contributor

If user has increased font size in their iOS settings it ends up clipping in the HUD.

image

@russfg
Copy link

russfg commented Aug 4, 2017

I see the issues above, but also the time under my charts is not spaced proportionally. I have the regular size iPhone 7, with the Settings>Display&Brightness>Text Size 1 below the max.
890719b2-3937-4018-a54d-38c1e081b07f png
654fd2e4-5e30-4512-bbdc-56905f7b5530 png

@gkirma
Copy link

gkirma commented Aug 21, 2017

I had this issue as well and decreased the font size but it didn't correct on my Loop screen. Please offer some suggestions? Thank you!

@ps2 ps2 mentioned this issue Sep 20, 2017
@ps2 ps2 closed this as completed in #584 Sep 20, 2017
ps2 added a commit that referenced this issue Nov 28, 2022
* [LOOP-4205] always display time changed alert when detected. retract when needed (#523)

* Adjust method to match updated protocol (#524)

* [LOOP-4289-4348] Critical alert modal and banner update (#525)

* initial pass at adding go to settings button in the critical alert modal

* remove foreground content from the riskMitigationAlert, since it is handle by the AlertManager

* added placeholder text for the alert premissions disabled banner

* add dismiss button to alert permissions disabled warning

* acknowledge alert with close option

* response to PR comments

* clean up

* more cleanup

* updated notification permissions banner

* updated style of alert permission disabled alert

* copy update

* [LOOP-4348] adjusted layout of notification permissions disabled banner (#527)

* [LOOP-4289] Also issue iOS notification (#528)

* issue notification permission alert when in background and retract in-app alert as needed

* remove unused code

* response to PR comments

* [LOOP-4348] notification permission banner for narrow display (#529)

* Fix crash in ZipArchiveTests (#530)

* [LOOP-4400] made status highlight container for CGM and pump pill the same size (#531)

* [LOOP-4349] Temporary mute alerts (#526)

* added placeholder UI to configure mute alerts duration

* checkpoint

* checkpoint

* initial commit at the alert muter

* minor clean-up

* removed unused file from project

* corrected predicate syntax

* all alerts at least vibrate

* checkpoint

* insteadOf = https://github.com/
updating unit tests

* checkpoint

* tighter coupling between alert manager and in-app/user notification alert issuers

* corrected rescheduling loop not running notifications and use timers for UI

* make the mute end period timer internval to the alert muter

* corrected typo

* updated unit tests

* added duration to temp mute alerts setting

* minor clean-up

* using source of truth for last loop date

* renamed Issuer -> Scheduler for in-app and user notification

* [LOOP-4349] corrected loop not looping rescheduling (#532)

* corrected identifier for loop not looping notifications

* updated test to run for both DIY and Tidepool

* COASTAL-1076 Support PumpManagerUI pausing onboarding (#533)

* Prevent marking onboarding as finished when pausing

* Update comment for clarity

* Use new iOS 16 method to notify VC of supported orientation change update (#534)

* [COASTAL-1124] Time alert copy update (#535)

* updated copy of time alert

* using device model

* Disable mute alerts feature (wip) and fix tests

Co-authored-by: Nathaniel Hamming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants