Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4256 (2): Old consent version is shown after setting has consent to false #3224

Conversation

SayakaOno
Copy link
Collaborator

Description

Check has_consent and consent_version in getUserFarmsSuccess and override has_consent before storing in the Redux store.

@SayakaOno SayakaOno self-assigned this Jun 6, 2024
@SayakaOno SayakaOno requested review from a team as code owners June 6, 2024 18:55
@SayakaOno SayakaOno requested review from Duncan-Brain and kathyavini and removed request for a team June 6, 2024 18:55
@SayakaOno SayakaOno changed the base branch from integration to LF-4256-old-consent-version-is-shown-after-setting-has-consent-to-false June 6, 2024 18:56
@SayakaOno SayakaOno changed the title LF-4256 (2): old consent version is shown after setting has consent to false LF-4256 (2): Old consent version is shown after setting has consent to false Jun 6, 2024
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooooooo much better, thank you ❤️ ❤️ ❤️ ❤️

@Duncan-Brain
Copy link
Collaborator

Oh yah thats a nice way to fix them all at once

@kathyavini kathyavini merged commit 99c2ebc into LF-4256-old-consent-version-is-shown-after-setting-has-consent-to-false Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants