-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF-4256 Old consent version is shown after setting has_consent
to false
#3222
Merged
kathyavini
merged 9 commits into
integration
from
LF-4256-old-consent-version-is-shown-after-setting-has-consent-to-false
Jun 10, 2024
Merged
LF-4256 Old consent version is shown after setting has_consent
to false
#3222
kathyavini
merged 9 commits into
integration
from
LF-4256-old-consent-version-is-shown-after-setting-has-consent-to-false
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathyavini
requested review from
Duncan-Brain and
SayakaOno
and removed request for
a team
June 5, 2024 22:49
Duncan-Brain
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising nice solution you two! So happy we don't have to add migrations anymore!
SayakaOno
approved these changes
Jun 7, 2024
4 tasks
kathyavini
added a commit
that referenced
this pull request
Jun 12, 2024
…-is-shown-after-setting-has-consent-to-false LF-4256 Old consent version is shown after setting `has_consent` to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
has_consent
as stored in the Redux store now takes into account consent version mismatch: LF-4256 (2): Old consent version is shown after setting has consent to false #3224Notes:
logout()
instead of routing to/consent
-- it would probably introduce a bit of complication and being more careful where that routing happens -- but I left it as is because I don't think the user experience is that badJira link: https://lite-farm.atlassian.net/browse/LF-4256
Type of change
How Has This Been Tested?
This demonstrates how the re-consenting is required. It should be merged together with the changes to the consent text (as will happen in the patch PR) for the timing to be correct.
Checklist: