Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4256 Old consent version is shown after setting has_consent to false #3222

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Jun 5, 2024

Description

This PR:

Notes:

  • It is the routes file check that had been triggering the need to re-consent upon first route change
  • We could instead logout() instead of routing to /consent -- it would probably introduce a bit of complication and being more careful where that routing happens -- but I left it as is because I don't think the user experience is that bad
  • In the future the only change necessary will be updating the consent version in the constants file along side the updated text

Jira link: https://lite-farm.atlassian.net/browse/LF-4256

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

This demonstrates how the re-consenting is required. It should be merged together with the changes to the consent text (as will happen in the patch PR) for the timing to be correct.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Jun 5, 2024
@kathyavini kathyavini requested review from a team as code owners June 5, 2024 22:49
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team June 5, 2024 22:49
SayakaOno and others added 4 commits June 6, 2024 10:38
…version-is-shown-after-setting-has-consent-to-false

LF-4256 (2): Old consent version is shown after setting has consent to false
Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising nice solution you two! So happy we don't have to add migrations anymore!

@kathyavini kathyavini added this pull request to the merge queue Jun 10, 2024
Merged via the queue into integration with commit 1799202 Jun 10, 2024
5 checks passed
kathyavini added a commit that referenced this pull request Jun 12, 2024
…-is-shown-after-setting-has-consent-to-false

LF-4256 Old consent version is shown after setting `has_consent` to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants