Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linux/arm64 platform to docker build-push-action #91

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Adding linux/arm64 platform to docker build-push-action #91

merged 4 commits into from
Mar 6, 2024

Commits on Sep 14, 2023

  1. Update Dockerfile (#43)

    Updates the Dockerfile with changes suggested by @GWnbsp  in #43 (comment)
    
    ### Summary of Changes
    1. **ARG Statements:** Introduced `ARG` statements for Node.js and Debian versions, making the Dockerfile more customizable.
    2. **SHELL Command:** Changed the default shell to Bash with certain options enabled, improving robustness.
    3. **Chromium Installation:** Updated Chromium installation to use Google's signing keys and repositories, aiming for more secure and up-to-date packages.
    4. **Chromium Version:** Added a step to save Chromium's version into `/etc/chromium-version` for reference.
    5. **Directory Creation:** Added a new directory /app/data in the container's filesystem.
    6. **CMD Change:** Changed the CMD to start Node.js server (server.js) instead of using yarn serve.
    7. **General Cleanup and Comments:** Code has been refactored for better readability and detailed comments have been added for clarity.
    8. **Dependency Installation:** Kept yarn install and the removal of the Yarn cache, but the command is more streamlined.
    9. **Other Minor Changes:**
      - Added flags like `-qq` and `--no-install-recommends` for quieter and optimized installation.
      - Enhanced cleanup with `rm -rf /var/lib/apt/lists/*.`
    Lissy93 authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a6711ae View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    2fb7dc9 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/FIX/chromium-docker' into patch-1

    # Conflicts:
    #	Dockerfile
    ChrisCarini committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    64fbcb3 View commit details
    Browse the repository at this point in the history
  3. Install python + increase yarn install timeout

    (cherry picked from commit 4e70e16)
    ChrisCarini committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    761f9da View commit details
    Browse the repository at this point in the history