Adding linux/arm64 platform to docker build-push-action #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Dockerfile with changes suggested by @GWnbsp in #43 (comment) ### Summary of Changes 1. **ARG Statements:** Introduced `ARG` statements for Node.js and Debian versions, making the Dockerfile more customizable. 2. **SHELL Command:** Changed the default shell to Bash with certain options enabled, improving robustness. 3. **Chromium Installation:** Updated Chromium installation to use Google's signing keys and repositories, aiming for more secure and up-to-date packages. 4. **Chromium Version:** Added a step to save Chromium's version into `/etc/chromium-version` for reference. 5. **Directory Creation:** Added a new directory /app/data in the container's filesystem. 6. **CMD Change:** Changed the CMD to start Node.js server (server.js) instead of using yarn serve. 7. **General Cleanup and Comments:** Code has been refactored for better readability and detailed comments have been added for clarity. 8. **Dependency Installation:** Kept yarn install and the removal of the Yarn cache, but the command is more streamlined. 9. **Other Minor Changes:** - Added flags like `-qq` and `--no-install-recommends` for quieter and optimized installation. - Enhanced cleanup with `rm -rf /var/lib/apt/lists/*.`
# Conflicts: # Dockerfile
(cherry picked from commit 4e70e16)
✅ Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Feb 29, 2024
Merged
Lissy93
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding linux/arm64 platform to docker build-push-action
Also merged in the changes from #55 (CC: @Lissy93 )
Additional Resources / Context
Turns out building a
arm64image for yarn projects on GitHub runners is less-easy than one might suspect. Specifically...Issue:
yarn installtimeoutsI encountered timeout issues pulling yarn dependencies, ultimately due to the emulation from QEMU. This can be worked around via extending the timeout to something long.
Solution: Adding
--frozen-lockfile --network-timeout 100000in theDockerfileIssue: missing python
I also encountered issues that python was missing from the path. A quick internet search showed that having
aptinstall this would likely resolve the issue.Solution: Adding
python make g++in theDockerfile(and, also merging in the changes from #55 )Resources
Below are some links/resources I found that helped me address these issues:
Details / Testing
I forked this repo to my own -> https://github.com/ChrisCarini/web-check (I may only keep this fork around for the life of this PR), changed .github/workflows/docker.yml#18 to be my
DOCKER_USERthen ran the workflow.Before
Before the change in this PR, the workflow succeeded, publishing an image with the single expected os/arch (
linux/amd64):After
I incorporated the change in this PR, and re-ran the workflow, which succeeded. As you can see below, the image was published with the two expected os/arch (
linux/amd64andlinux/arm64):Bug(s)
Fixes #73