Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Config not saving troubleshooting #1474

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Conversation

CrazyWolf13
Copy link
Collaborator

@CrazyWolf13 CrazyWolf13 commented Feb 24, 2024

CrazyWolf13 Medium CrazyWolf13 /master → Lissy93/dashy Commits: 4 | Files Changed: 2 | Additions: 22 Unchecked Tasks Powered by Pull Request Badge

Category:

Docs

Overview

Added the config not saving troubleshooting mentioned in #1147

Issue Number (if applicable) #1147

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

CrazyWolf13 and others added 2 commits February 24, 2024 23:18
Fixed a little typo and added a more specific url
Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 10:44pm

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b05f057
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65da710045dbb1000824bed1
😎 Deploy Preview https://deploy-preview-1474--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do already have a WIP update on this in c8b3047
Tho actually your explanation does look clearer

@CrazyWolf13
Copy link
Collaborator Author

I do already have a WIP update on this in c8b3047 Tho actually your explanation does look clearer

Ohhps, did not see that, looked into the other 2.1.2 branch.

If you like mine more, I can integrate your texts as well, so we can have only one PR about this. Otherwise I'll close mine.

@CrazyWolf13
Copy link
Collaborator Author

@Lissy93 Included you texts right into mine. Apologizes for interfering with your PR.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, looks good, will merge now

@Lissy93 Lissy93 merged commit faafa60 into Lissy93:master Feb 24, 2024
8 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants