Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config not saving #1147

Closed
5 tasks done
HighSunMurder opened this issue Mar 20, 2023 · 31 comments
Closed
5 tasks done

Config not saving #1147

HighSunMurder opened this issue Mar 20, 2023 · 31 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🛩️ Released 2.1.2

Comments

@HighSunMurder
Copy link

Environment

Self-Hosted (Docker)

System

Ubuntu

Version

Current

Describe the problem

Any changes i make in dashboard i save to disk via UI, If i reboot the server these changes are gone and dashy is vanilla / default

Additional info

No response

Please tick the boxes

@HighSunMurder HighSunMurder added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Mar 20, 2023
@liss-bot

This comment was marked as spam.

@ulysserevient
Copy link

Same problem here !
Unable to save conf.yml from the UI
The backup file is created, but the conf.yml isn't saved !

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 31, 2023
@HighSunMurder
Copy link
Author

HighSunMurder commented Mar 31, 2023 via email

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 1, 2023
@liss-bot

This comment was marked as spam.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label May 2, 2023
@ulysserevient
Copy link

I still can't save the conf file from the gui
is there a solution ?

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels May 2, 2023
@rongalbraith
Copy link

rongalbraith commented May 15, 2023

I have had the same issue. I get an error "AxiosError: Network Error". This wasn't always happening and I wasn't sure why.

Anyway, I was a little lazy in my implementation and had just used default (root) login to run the Dashy container. I've since switched it to using a non-root user (changed ownership of the folder structure) and everything is working fine now. Shouldn't have made a difference but I'll keep this updated in case I have any further issues.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 16, 2023
@minisculemarch
Copy link

Same issue, regarding the file not saving but the backup is created. Rebuild also fails randomly, 503. I've found it easier to simply edit the conf file manually the restart the docker container.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 22, 2023
@rongalbraith
Copy link

So, for me the answer was to implement a non-root installation for the container. Not sure why it worked but there's obviously some conflict somewhere that doesn't occur when you're container is running under a non-root user.

Just added UID and GID environment variables:
# Set any environmental variables
environment:
# Specify your user ID and group ID. You can find this by running id -u and id -g
- UID=1001
- GID=1001

Bear in mind that "1001" was my default user and your user may be different. Quick chown -R in the terminal for the folders where I was storing the persistent volume for Dashy, bounced the container and everything has been fine since.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 23, 2023
@Glitch3dPenguin
Copy link
Contributor

I have been having a similar issue. I’m going to give this a shot as well and see if I make and progress. Thanks for the recommendation!

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 26, 2023
@matteo-martinelli
Copy link

I have the same issue. Any kind of change is not update. Backups are made, but any change is effective.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 27, 2023
@ulysserevient
Copy link

Hi,
I've tried to change UID and GID with non-root user, but problem persists !

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 27, 2023
@offline09
Copy link

Hi, I am having the same problem, set all my links up then boom, everything gone. Tried the non-root user change, and still broken.

@strangedesign13
Copy link

strangedesign13 commented Jul 12, 2023

Not sure if this is the intended design of dashy or if there is a bug, but what I finally found worked had nothing to do root owner. After editing hit “Save to Disk”, then open “Update Configuration” (the wrench icon) and then select “Rebuild Application”. After it completes, I have had no issues with refreshing the dashboard, closing it and repointing it.

While saving a config doesn’t trigger the rebuild, I’m not sure but this has solved the issue for me.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jul 13, 2023
@avaaum
Copy link

avaaum commented Sep 26, 2023

i had this same issue that caused me to loose all my edits multiple times. edited fonts and colors did not stick after saving to disk multiple times, but menus, menu items and icons did. @strangedesign13's workaround above finally did the trick. i feel the expected behavior is for the "save to disk" function to trigger the "rebuild application" function. fwiw i'm using ff/librewolf and everything is up to date. plz look into this. thx again for your work. dashy is awesome 💜

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Sep 26, 2023
@Lissy93
Copy link
Owner

Lissy93 commented Feb 24, 2024

I think there may be a several different issues here,

Possible Issue 1: Unable to call save endpoint from CDN/static server

If you're running Dashy on a static host, like Vercel, then there's no server-side code to actually save the config, re: #1465 (this is outlined bit more in the docs)

Possible Issue 2: Unable to save

In Docker, double check that the file isn't read-only, and that the container actually has permissions to modify it. You shouldn't really be running it as a root user, and I'm not sure if it will work if you do

Possible Issue 3: Saved but not updating

After saving, the frontend will recompile, which may take a couple seconds (or a bit longer on a Pi or low-powered device). If it doesn't recompile, you can manually trigger a re-build.

None of the above?

If you're still having issues, if you could share the following with me, it'll help me look into it further:

  • If you open the conf.yml file, can you see your changes?
  • When you save, are there any errors in the browser console (see: how to open browser console)
  • Are there any errors in your Docker logs?

@CrazyWolf13
Copy link
Collaborator

Hi
This problems seems to be related to dashy not automatically rebuilding on changes (#1147 (comment)) , see #1479 and #1290 (comment)
A new release has just been published, which should fix this issue, so please upgrade to the latest version.
If this is not the case just respond back to this ticket and I'll reopen this issue.
Thanks and have a nice day.

@github-project-automation github-project-automation bot moved this from Awaiting Triage to Done in Dashy V3 Mar 3, 2024
@wilcomir
Copy link

wilcomir commented Mar 31, 2024

Hello,

I am still having issues with this - saving the configuration via the gui does not work properly.

I am using docker-compose, setting UID and GID to my user (1000:1000). I am passing through a whole folder to the container, permissions of the folder and all the files within are correct.

When I make a modification from the GUI, a backup file is created - therefore dashy can write to the folder - but the new conf.yaml is... not new, it's just the same. I see no error in the docker log, when I hit save a rebuild is correctly triggered, no error in the browser console as well.

I tried all permutations that I could think of, running the container without UID/GID, changing ownership of the folder to root:root, making the folder & contents chmod 777...

I am unsure how to proceed, I love this project and I am willing to perform any troubleshooting that might be necessary.

I have performed a bit of debugging, and noticed that even if I run the container with UID:GID set, the backup files are still saved as root. Inside the container itself, I see that the 1000:1000 files are (presumably) correctly mapped to user node, including conf.yaml

@CrazyWolf13 CrazyWolf13 reopened this Mar 31, 2024
@rawGH
Copy link

rawGH commented Apr 14, 2024

I have the same exact issue. Dashy works. Installation/Configuration is done properly. I've been configuring Dashy for a couple of days now with little to no issues. However I am not able to edit config file via GUI. I mean I could do it the first time but never again after that. Changes are never really saved, even though saving confirmation is shown as successful.
I've tried waiting, reloading and rebuilding with no success.
Ver. 2.1.2
Edit: temp solution: edited conf.yml manually (docker).
Edit2: did some light observing. Upon saving, two files are affected: seems that the old config version is saved into conf.xxx.backup.yml and conf.yml. In any case, it doesn't look like a permission problem, as files are written/updated.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Apr 14, 2024
@shalithasuranga
Copy link

shalithasuranga commented Apr 16, 2024

I had the same issue. Now, I just do preview changes -> save to disk from the JSON editor. This workaround works very well and is easy 🎉

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 16, 2024
@rawGH
Copy link

rawGH commented Apr 16, 2024

I had the same issue. Now, I just do preview changes -> save to disk from the JSON editor. This workaround works very well and is easy 🎉

I've tested, but it does not work for me. I can edit "tree" (eg changing the order of sections) and save then, it works. Changes might require rebuild or reload page, but it works. The bug appears only when "code" is used and changed anything (even a string or something), it's never saved, using "Preview Changes" does nothing in this case.
When checking the actual files upon saving, two are affected. Backup and normal conf.yml, but contents are the same, as is the timestamp of both files, unfortunately the saved version is the previous one, so no actual changes were stored.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 17, 2024
@jonathantalkshw
Copy link

I just found out that when you click "tree" which give you a dropdown menu, and the other options is "code" and "preview", click on code, then make some changes, then hit "preview changes", then "save to disk". but I have not tried without changing the menu next to the undo & redo button before doing the preview changes, that could work. and the way I did actually updated it, even if I refreshed my dashy page.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 18, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Apr 20, 2024

Try V3, there should be no more issues with this anymore

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 20, 2024
@Lissy93 Lissy93 added the 🚏 Awaiting User Response [ISSUE] Response from original author is pending label Apr 20, 2024
@rawGH
Copy link

rawGH commented Apr 20, 2024

Did a quick recreate docker to v3. Tested for about 10min, all seems to be working now. Thanks L.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 🚏 Awaiting User Response [ISSUE] Response from original author is pending labels Apr 20, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🛩️ Released 2.1.2
Projects
Status: Done
Development

No branches or pull requests