Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update manifest.json's start_url to bare root path #1026

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

kieraneglin
Copy link
Contributor

@kieraneglin kieraneglin commented Dec 28, 2022

kieraneglin Quick kieraneglin /FIX/add-to-homescreen-404 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label

Category:

Bugfix

Overview

The "add to homescreen" functionality on Android is broken. When adding your dashboard to your homescreen it points to /index.html which, in some server/proxy configurations, redirects to a 404 page. In my case I'm running a self-hosted Docker container.

Judging by some issue comments, this may also fix an authentication bug but I cannot confirm this.

Issue Number #988 is the main one, but based on comments #1019 may also be resolved. #628 is also related but more for context than anything.

Code Quality Checklist

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Dec 28, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit da3b5bc
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63ac8b88b3fd64000891a834
😎 Deploy Preview https://deploy-preview-1026--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Dec 28, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@kieraneglin
Copy link
Contributor Author

I've confirmed via the netlify deployment URL that adding to homescreen is now successful 👍

@liss-bot
Copy link
Collaborator

This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jan 28, 2023
@kieraneglin
Copy link
Contributor Author

It's still valid - just awaiting review

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Jan 28, 2023
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry for the delay, somehow missed the notification
But looks good 👍

@Lissy93 Lissy93 merged commit 221aeb5 into Lissy93:master Jan 29, 2023
@kieraneglin
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants