-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update manifest.json's start_url to bare root path #1026
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Changes preview: |
I've confirmed via the netlify deployment URL that adding to homescreen is now successful 👍 |
This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days. |
It's still valid - just awaiting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry for the delay, somehow missed the notification
But looks good 👍
Thank you! |
Category:
Overview
Issue Number #988 is the main one, but based on comments #1019 may also be resolved. #628 is also related but more for context than anything.
Code Quality Checklist