Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] redirect keycloak stopped working #1019

Closed
5 tasks done
wolflarson opened this issue Dec 25, 2022 · 12 comments
Closed
5 tasks done

[BUG] redirect keycloak stopped working #1019

wolflarson opened this issue Dec 25, 2022 · 12 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive

Comments

@wolflarson
Copy link

Environment

Self-Hosted (Docker)

System

Firefox 108.0.1 (64-bit) on Manjaro (KDE)

Version

2.1.1

Describe the problem

While on 2.1.1 redirect to keycloak is not forced. Downgrading to 2.1.0 correctly forces login via keycloak before showing dashboard.

This is the auth block. My config is not changing between versions. Upgrade to 2.1.1 and no login needed. Downgraded and I'm forced to login via keycloak before I can interact. This might actually be a security issue because on 2.1.1 I can edit the config yaml without logging in.

  auth:
    enableGuestAccess: false
    users: []
    enableKeycloak: true
    keycloak:
      serverUrl: https://auth.example.com
      realm: example
      clientId: dashy
      legacySupport: false

I reset the config file to stock and only changed this auth block to replicate the issue before opening a bug. Full config can be found here.

Additional info

keycloak:20.0.2

Please tick the boxes

@wolflarson wolflarson added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Dec 25, 2022
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@allesauseinerhand
Copy link

Probably the same source of bug for this problem: #990

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Dec 28, 2022
@ouafnico
Copy link

ouafnico commented Jan 2, 2023

I actually got the same bug on 2.1.1.
I have to use 2.1.0 too.

On 2.1.1, the "disconnect" button is present, but does nothing, and I can't go to the login page.

Thanks btw for dashy, it's very good !

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 3, 2023
@djessich
Copy link

djessich commented Jan 4, 2023

I switched back to 2.1.0. Version 2.1.1 stopped working for me too.
After some time, Dashy does not redirect anymore, so redirection is not forced.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 4, 2023
@kieraneglin
Copy link
Contributor

This may have been fixed by #1026 but I have not confirmed

@wolflarson
Copy link
Author

Should the 2.1.1 docker container include that change at this point? I can test quickly if there is a container built already .

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 31, 2023
@ouafnico
Copy link

ouafnico commented Feb 1, 2023

I'm using the 2.1.1 but I still got a bug : guest access is not working, and got a continuous refresh of page.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 1, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 4, 2023

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Mar 4, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 9, 2023

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot closed this as completed Mar 9, 2023
@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Mar 9, 2023
@zell-mbc
Copy link

This one shows as closed, but it isn't for me. I was running v2.1.1 until today when I realised that my dashboard has been unprotected since December.
I would actually think this should be treated like a pretty serious/security related regression?

A downgrade to v.2.0.0 as recommended higher up, made things working again.

@TheRealGramdalf
Copy link

See #1290 (comment) for a full explanation/semi solution

For notifications:
@jakob1379 @zell-mbc @ouafnico @wolflarson @kieraneglin @djessich @allesauseinerhand
Sorry if you didn't want to be pinged, but I figure you probably did - or you wouldn't have participated in the issue

@jakob1379
Copy link

See #1290 (comment) for a full explanation/semi solution

For notifications:
@jakob1379 @zell-mbc @ouafnico @wolflarson @kieraneglin @djessich @allesauseinerhand
Sorry if you didn't want to be pinged, but I figure you probably did - or you wouldn't have participated in the issue

My isse was a misconfiguration with keycloak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

10 participants