This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Token module metadata references request schema for response endpoint #7660
Comments
shuse2
added a commit
that referenced
this issue
Oct 29, 2022
### What was the problem? This PR resolves #7579 #7660 ### How was it solved? * Fixed `TokenModule.init()` to get config from a `ModuleConfig` object * Implemented `isSupported` endpoint * Implemented `getInitializationFees` endpoint * Partially implemented `getSupportedTokens` endpoint ### How was it tested? Added unit tests. Skipped the one that should return false when checking if a not-supported token is supported. Co-authored-by: shuse2 <[email protected]>
ishantiw
pushed a commit
that referenced
this issue
Nov 15, 2022
### What was the problem? This PR resolves #7579 #7660 ### How was it solved? * Fixed `TokenModule.init()` to get config from a `ModuleConfig` object * Implemented `isSupported` endpoint * Implemented `getInitializationFees` endpoint * Partially implemented `getSupportedTokens` endpoint ### How was it tested? Added unit tests. Skipped the one that should return false when checking if a not-supported token is supported. Co-authored-by: shuse2 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Response should reference the response schema, not request schema. Probably a copy-paste error.
https://github.com/LiskHQ/lisk-sdk/blob/d7e2214a3a2f134e0f38d2e72401aacb5e70d95d/framework/src/modules/token/module.ts#L97
The text was updated successfully, but these errors were encountered: