This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update Token module endpoints - Closes #7579 #7660 #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobanm
changed the title
Base automatically changed from
7694-remove-redundant-module-config-interface
to
feature/7211-update_token_module
October 27, 2022 23:22
shuse2
reviewed
Oct 28, 2022
…()` and `supportAll()`
bobanm
changed the title
shuse2
approved these changes
Oct 29, 2022
ishantiw
pushed a commit
that referenced
this pull request
Nov 15, 2022
### What was the problem? This PR resolves #7579 #7660 ### How was it solved? * Fixed `TokenModule.init()` to get config from a `ModuleConfig` object * Implemented `isSupported` endpoint * Implemented `getInitializationFees` endpoint * Partially implemented `getSupportedTokens` endpoint ### How was it tested? Added unit tests. Skipped the one that should return false when checking if a not-supported token is supported. Co-authored-by: shuse2 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7579 #7660
How was it solved?
TokenModule.init()to get config from aModuleConfigobjectisSupportedendpointgetInitializationFeesendpointgetSupportedTokensendpointHow was it tested?
Added unit tests. Skipped the one that should return false when checking if a not-supported token is supported.