Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update token module endpoints #7579

Closed
Tracked by #7211
shuse2 opened this issue Sep 23, 2022 · 0 comments
Closed
Tracked by #7211

Update token module endpoints #7579

shuse2 opened this issue Sep 23, 2022 · 0 comments
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Sep 23, 2022

Description

  1. Add token module endpoint getInitializationFees which returns below using config
{
  "userAccount": "50000000",
  "escrowAccount": "50000000",
}
  1. Update token module endpoints to use updated stores referring to LIP stores
  2. Add token module endpoint isSupported
    req
{
  tokenID: '',
}

res

{
  supported: true
}
  1. Add token module endpoint getSupportedTokens
    res
  supportedTokens: []

where array should include ['*'] when all tokens are supported. It should also include mainchain / native tokens.
If all native token from a chain is supported, it should return ['00000020********']

Acceptance Criteria

  • It should be reflected in the metadata
  • Unit test for the endpoint is added

Additional Information

@shuse2 shuse2 added this to the Sprint 79 milestone Sep 26, 2022
@shuse2 shuse2 changed the title Add token module endpoint getInitializationFees Update token module endpoints Sep 28, 2022
@shuse2 shuse2 modified the milestones: Sprint 79, Sprint 80 Oct 10, 2022
@bobanm bobanm self-assigned this Oct 17, 2022
@shuse2 shuse2 modified the milestones: Sprint 80, Sprint 81 Oct 24, 2022
shuse2 added a commit that referenced this issue Oct 29, 2022
### What was the problem?

This PR resolves #7579 #7660

### How was it solved?

* Fixed `TokenModule.init()` to get config from a `ModuleConfig` object
* Implemented `isSupported` endpoint
* Implemented `getInitializationFees` endpoint
* Partially implemented `getSupportedTokens` endpoint

### How was it tested?

Added unit tests. Skipped the one that should return false when checking
if a not-supported token is supported.

Co-authored-by: shuse2 <[email protected]>
@shuse2 shuse2 closed this as completed Oct 29, 2022
ishantiw pushed a commit that referenced this issue Nov 15, 2022
### What was the problem?

This PR resolves #7579 #7660

### How was it solved?

* Fixed `TokenModule.init()` to get config from a `ModuleConfig` object
* Implemented `isSupported` endpoint
* Implemented `getInitializationFees` endpoint
* Partially implemented `getSupportedTokens` endpoint

### How was it tested?

Added unit tests. Skipped the one that should return false when checking
if a not-supported token is supported.

Co-authored-by: shuse2 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants