-
Notifications
You must be signed in to change notification settings - Fork 13
Update LIP0052 - improve code readability, improve/add functions, typos #477
Update LIP0052 - improve code readability, improve/add functions, typos #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have forgot to address item 4 from the issue:
In the
getChainID
function, the check for thenftID
length is missing, while it exists in the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
… code to reflect changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions to be more consistent with emitting event, otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial approval
Resolves Issue #476, Issue #478, Issue #479, and Issue #483.