Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update LIP0052 - improve code readability, improve/add functions, typos #477

Merged
merged 17 commits into from
Sep 15, 2023
Merged

Update LIP0052 - improve code readability, improve/add functions, typos #477

merged 17 commits into from
Sep 15, 2023

Commits on Sep 4, 2023

  1. improve code readability, functions, typos

    @mjerkov
    mjerkov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    6fa40a9 View commit details
    Browse the repository at this point in the history

  2. apply Sergey's comments

    @mjerkov
    mjerkov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    eaafef8 View commit details
    Browse the repository at this point in the history

  3. refactor transfer verification

    @mjerkov
    mjerkov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    8330bda View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. move event definitions to verify functions

    @mjerkov
    mjerkov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b07f30a View commit details
    Browse the repository at this point in the history

  2. remove messageFeeTokenID from crossChainNFTTransferParamsSchema

    @mjerkov
    mjerkov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d7c4ff4 View commit details
    Browse the repository at this point in the history

  3. remove NFT store check for nftID in verifyTransferInternal and verify… 

    …TransferCrossChainInternal
    @mjerkov
    mjerkov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b9394ea View commit details
    Browse the repository at this point in the history

  4. remove NFT store check for nftID in destroy and unlock

    @mjerkov
    mjerkov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ae13091 View commit details
    Browse the repository at this point in the history

  5. introduce getNFT

    @mjerkov
    mjerkov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b674bb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. introduce getNFT, remove redundant functions and refactor rest of the… 

    … code to reflect changes
    @mjerkov
    mjerkov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    58e4ba6 View commit details
    Browse the repository at this point in the history

  2. add events if NFT does not exist

    @mjerkov
    mjerkov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    876ae2c View commit details
    Browse the repository at this point in the history

  3. outdent

    @mjerkov
    mjerkov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d95f441 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. improve CCM execution, recover and support functions

    @mjerkov
    mjerkov committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ca1bd3e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. add condition to cross-chain transfer CCM verification

    @mjerkov
    mjerkov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0e9b648 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. remove LENGTH_TOKEN_ID

    @mjerkov
    mjerkov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    87b5555 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. move module is not nft check to the beginning of lock function

    @mjerkov
    mjerkov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2caa0d4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into update_lip_0052_improve_readability_function… 

    …s_typos
    @janhack
    janhack committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9c43524 View commit details
    Browse the repository at this point in the history

  3. Perform editorial edits

    @janhack
    janhack committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    99d7ff3 View commit details
    Browse the repository at this point in the history