Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove code redundancy in transfer methods of NFT module #8954

Closed
Tracked by #7245
Incede opened this issue Sep 11, 2023 · 0 comments
Closed
Tracked by #7245

Remove code redundancy in transfer methods of NFT module #8954

Incede opened this issue Sep 11, 2023 · 0 comments
Assignees
@bobanm
Labels
framework
Milestone
Sprint 105

Comments

@Incede
Copy link
Contributor

Incede commented Sep 11, 2023

Description

  • In NFT module, transfer function and command, as well as cross-chain transfer function and command, have unnecessary code duplication in the verification part.
  • Factorize the repeating verification code for the transfer command and method into a verifyTransferInteral function.
  • Factorize the repeating verification code for the cross-chain transfer command and method into a a verifyTransferCrossChainInternal function.

Acceptance Criteria

  • All relevant changes in the LIP PR must be incorporated
  • Unit tests must be updated

Additional Information

LIP PR
@bobanm bobanm self-assigned this Sep 12, 2023
@Madhulearn Madhulearn added this to the Sprint 104 milestone Sep 12, 2023
@Madhulearn Madhulearn mentioned this issue Sep 12, 2023
Closed
66 tasks
@bobanm bobanm mentioned this issue Sep 19, 2023
Merged
@Madhulearn Madhulearn modified the milestones: Sprint 104, Sprint 105 Sep 25, 2023
@shuse2 shuse2 closed this as completed Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobanm bobanm

Labels
framework
Projects
None yet
Milestone
Sprint 105
Development

No branches or pull requests
4 participants
@shuse2 @bobanm @Incede @Madhulearn