Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Added LSK check on beforeCrossChainMessageForwarding #8806

Merged
merged 13 commits into from
Aug 10, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Aug 4, 2023

What was the problem?

This PR resolves #8602

How was it solved?

How was it tested?

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #8806 (126bab0) into release/6.0.0 (47e3191) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8806      +/-   ##
=================================================
- Coverage          83.37%   83.36%   -0.01%     
=================================================
  Files                596      596              
  Lines              22421    22427       +6     
  Branches            3305     3307       +2     
=================================================
+ Hits               18693    18697       +4     
- Misses              3728     3730       +2     
Files Changed Coverage Δ
...s/interoperability/base_interoperability_method.ts 96.42% <66.66%> (-3.58%) ⬇️
framework/src/modules/fee/cc_method.ts 100.00% <100.00%> (ø)
framework/src/modules/token/cc_method.ts 100.00% <100.00%> (ø)

@Phanco Phanco marked this pull request as ready for review August 4, 2023 13:23
@Phanco Phanco requested review from ishantiw and ricott1 August 4, 2023 13:23
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a minor comment

@Phanco Phanco requested a review from ishantiw August 8, 2023 08:54
Copy link
Contributor

@ricott1 ricott1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one optional comment

@Phanco Phanco requested a review from gkoumout August 10, 2023 09:07
@shuse2 shuse2 merged commit 3a280f7 into release/6.0.0 Aug 10, 2023
10 checks passed
@shuse2 shuse2 deleted the 8602-beforeCrossChainMessageForwarding-lsk-only branch August 10, 2023 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants