This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Added LSK check on beforeCrossChainMessageForwarding #8806
Merged
shuse2
merged 13 commits into
release/6.0.0
from
8602-beforeCrossChainMessageForwarding-lsk-only
Aug 10, 2023
Merged
Added LSK check on beforeCrossChainMessageForwarding #8806
shuse2
merged 13 commits into
release/6.0.0
from
8602-beforeCrossChainMessageForwarding-lsk-only
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8806 +/- ##
=================================================
- Coverage 83.37% 83.36% -0.01%
=================================================
Files 596 596
Lines 22421 22427 +6
Branches 3305 3307 +2
=================================================
+ Hits 18693 18697 +4
- Misses 3728 3730 +2
|
ishantiw
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a minor comment
framework/src/modules/interoperability/base_interoperability_method.ts
Outdated
Show resolved
Hide resolved
…beforeCrossChainMessageForwarding-lsk-only
…beforeCrossChainMessageForwarding-lsk-only
…beforeCrossChainMessageForwarding-lsk-only
ishantiw
approved these changes
Aug 8, 2023
ricott1
approved these changes
Aug 9, 2023
…beforeCrossChainMessageForwarding-lsk-only
ricott1
reviewed
Aug 9, 2023
framework/src/modules/interoperability/base_interoperability_method.ts
Outdated
Show resolved
Hide resolved
gkoumout
reviewed
Aug 9, 2023
ricott1
reviewed
Aug 9, 2023
framework/src/modules/interoperability/base_interoperability_method.ts
Outdated
Show resolved
Hide resolved
ricott1
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one optional comment
…beforeCrossChainMessageForwarding-lsk-only
…beforeCrossChainMessageForwarding-lsk-only
ishantiw
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8602
How was it solved?
How was it tested?