Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

CCM fees are under-specified and the implementation is not defensive #8602

Closed
Tracked by #7226
ishantiw opened this issue Jun 16, 2023 · 0 comments
Closed
Tracked by #7226

CCM fees are under-specified and the implementation is not defensive #8602

ishantiw opened this issue Jun 16, 2023 · 0 comments
Assignees
Labels
framework/module/interoperability Interoperability module
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jun 16, 2023

Description

if the beforeCrossChainMessageForwarding function of the token module should only work with LSK, then add a check to ensure that messageFeeTokenID is always LSK. Create a function that, given a CCM, returns the messageFeeTokenID. This will reduce the ambiguity of using receivingChainID or sendingChainID, and ensure that all functions use the same.

  • Add getMessageFeeTokenIDFromCCM method to Interoperability module

Acceptance Criteria

  • Should pass all the unit tests

Additional Information

Relevant LIP PRs,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework/module/interoperability Interoperability module
Projects
None yet
Development

No branches or pull requests

4 participants