This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Merge Feature/6930 implement poa module to development #8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bootstrap PoA files and folders * Update method names on module.ts * Replace .keep to index.ts for folders * Add bootstrap test file * Rename internal method to PoAInternalMethod
* Bootstrap PoA files and folders * Update method names on module.ts * Replace .keep to index.ts for folders * Add bootstrap test file * Create events and register of the said event * Update enum name
* 🌱 Initialize stores * ♻️ Update names and register stores * 💅 Rename snapshotStoreSchema->snapshotSchema
* Define genesis PoA store schema & relevant types * `length' replaced with `minLength` & `maxLength` * Add missing $id
* Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Change name of updateAuthoritySchema
* 🌱 Implement afterTransactionsExecute and _shuffleValidatorsList * ✅ Add unit tests for afterTransactionsExecute and shuffleValidatorList * ♻️ Use constants and simplify shuffleValidatorList * ✅ Adjust expectation setValidatorsParams to expect secondSnapshot threshold * 💅🏻 Rename snapshot keys * ♻️ Add missing logic and improve logic for afterTransactionsExecute * 💅🏻 Assert type on the arguments for readability * ♻️Naming issues and refine loop in test
* Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Implement Update Authority and Test Cases * Change name of updateAuthoritySchema * Update updateAuthoritySchema naming * Update update authority coding according to PR comments * Edited Buffer bits and test cases captions * Update cosmetic change on update_authority files * Add comments and better error message to UpdateAuthorityCommand * Minor changes to error message captions * Update error message caption
* Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Implement Update Authority and Test Cases * Change name of updateAuthoritySchema * Implement UpdateGeneratorKey and Test Cases * Update updateAuthoritySchema naming * Update update authority coding according to PR comments * Edited Buffer bits and test cases captions * Update cosmetic change on update_authority files * Update UpdateGeneratorKeyCommand to use senderAddress * Add comments and better error message to UpdateAuthorityCommand * Minor changes to error message captions * Update error message caption --------- Co-authored-by: !shan <[email protected]>
* Add PoA constants, schemas and types * Implement proof of authority genesis initialization * Update error messages in poa module initGenesis * Export types and fix snapshotstore type * Implement tests for poa genesis initialization * Remove unused validators from test * Update snapshot storage * Implement finalizeGenesisState * Update lint no-console place holder --------- Co-authored-by: Mitsuaki Uchimoto <[email protected]>
* Implement PoA module endpoints * Add getRegistrationFee endpoint --------- Co-authored-by: Mitsuaki Uchimoto <[email protected]>
* ♻️ Resolve dependencies and add configurable constant * ♻️ Use authorityRegistrationFee in endpoint and fix test
Co-authored-by: !shan <[email protected]>
Expose Commands on PoA
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8789 +/- ##
===============================================
+ Coverage 83.39% 83.57% +0.18%
===============================================
Files 593 610 +17
Lines 22289 22675 +386
Branches 3286 3317 +31
===============================================
+ Hits 18587 18951 +364
- Misses 3702 3724 +22
|
* Add PoA example * Update PoA Genesis * Update README and remove uncessary genesis json * Update application.ts to accept PoS and PoA * Add Reward Module to PoA * Renaming poa to sidechain * Revert application.ts * Move setValidatorsParams to under registerValidatorKeys * Register module inside the PoA * Add RewardModule and revert module.ts (Changes in separate PR) * Add sign scripts for updateAuthority.ts * Update yarn.lock
Co-authored-by: !shan <[email protected]>
* Update getAllValidators Endpoint * Update test cases for poa_getAllValidators * Sort response by name on getAllValidators function * Update PoA test cases * Update code per PR comments --------- Co-authored-by: Khalid Hameed <[email protected]>
ishantiw
force-pushed
the
feature/6930-implement-poa-module
branch
from
July 31, 2023 17:54
372bae0
to
058cebd
Compare
shuse2
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6930
How was it solved?
How was it tested?