This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
PoA Register Authority Command #8496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phanco
changed the title
Phanco
changed the base branch from
development
to
feature/6930-implement-poa-module
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6930-implement-poa-module #8496 +/- ##
=====================================================================
+ Coverage 83.16% 83.45% +0.28%
=====================================================================
Files 606 607 +1
Lines 22343 22394 +51
Branches 3258 3261 +3
=====================================================================
+ Hits 18582 18688 +106
+ Misses 3761 3706 -55
|
Phanco
force-pushed
the
8413-register-authority-commands
branch
from
e37f9c8
to
b6be097
Compare
Phanco
requested review from
ishantiw,
sitetester and
mitsuaki-u
and removed request for
sitetester
sitetester
changed the title
sitetester
suggested changes
May 26, 2023
framework/test/unit/modules/poa/commands/register_authority.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/poa/commands/register_authority.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/poa/commands/register_authority.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
suggested changes
May 30, 2023
framework/test/unit/modules/poa/commands/register_authority.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
approved these changes
Jun 1, 2023
sitetester
reviewed
Jun 1, 2023
…/lisk-sdk into 8413-register-authority-commands
mitsuaki-u
approved these changes
Jun 2, 2023
ishantiw
approved these changes
Jun 5, 2023
ishantiw
pushed a commit
that referenced
this pull request
Jul 31, 2023
* Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Change name of updateAuthoritySchema
ishantiw
added a commit
that referenced
this pull request
Aug 1, 2023
* Bootstrap PoA files and folders (#8456) * Bootstrap PoA files and folders * Update method names on module.ts * Replace .keep to index.ts for folders * Add bootstrap test file * Rename internal method to PoAInternalMethod * Implement events for PoA (#8464) * Bootstrap PoA files and folders * Update method names on module.ts * Replace .keep to index.ts for folders * Add bootstrap test file * Create events and register of the said event * Update enum name * Add stores to PoA module (#8466) * 🌱 Initialize stores * ♻️ Update names and register stores * 💅 Rename snapshotStoreSchema->snapshotSchema * Define genesis PoA store schema & relevant types (#8501) * Define genesis PoA store schema & relevant types * `length' replaced with `minLength` & `maxLength` * Add missing $id * PoA Register Authority Command (#8496) * Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Change name of updateAuthoritySchema * Implement afterTransactionsExecute and _shuffleValidatorsList (#8523) * 🌱 Implement afterTransactionsExecute and _shuffleValidatorsList * ✅ Add unit tests for afterTransactionsExecute and shuffleValidatorList * ♻️ Use constants and simplify shuffleValidatorList * ✅ Adjust expectation setValidatorsParams to expect secondSnapshot threshold * 💅🏻 Rename snapshot keys * ♻️ Add missing logic and improve logic for afterTransactionsExecute * 💅🏻 Assert type on the arguments for readability * ♻️Naming issues and refine loop in test * Implement update authority command (#8527) * Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Implement Update Authority and Test Cases * Change name of updateAuthoritySchema * Update updateAuthoritySchema naming * Update update authority coding according to PR comments * Edited Buffer bits and test cases captions * Update cosmetic change on update_authority files * Add comments and better error message to UpdateAuthorityCommand * Minor changes to error message captions * Update error message caption * Implement PoA Update Generator Key (#8534) * Implement Register Authority Commands * Renaming Commands * Remove extra files * Added Unit Test for RegisterAuthority * Put types back to PoA * Update code according to PR review and comments * Update chainID in test case to match with actual format * Update param names to be grammar-correct * Update AUTHORITY_REGISTRATION_FEE comments and test unit imports * Update $id for updateAuthority Schema * Implement Update Authority and Test Cases * Change name of updateAuthoritySchema * Implement UpdateGeneratorKey and Test Cases * Update updateAuthoritySchema naming * Update update authority coding according to PR comments * Edited Buffer bits and test cases captions * Update cosmetic change on update_authority files * Update UpdateGeneratorKeyCommand to use senderAddress * Add comments and better error message to UpdateAuthorityCommand * Minor changes to error message captions * Update error message caption --------- Co-authored-by: !shan <[email protected]> * Implement proof of authority genesis initialization (#8525) * Add PoA constants, schemas and types * Implement proof of authority genesis initialization * Update error messages in poa module initGenesis * Export types and fix snapshotstore type * Implement tests for poa genesis initialization * Remove unused validators from test * Update snapshot storage * Implement finalizeGenesisState * Update lint no-console place holder --------- Co-authored-by: Mitsuaki Uchimoto <[email protected]> * Implement PoA module endpoints (#8581) * Implement PoA module endpoints * Add getRegistrationFee endpoint --------- Co-authored-by: Mitsuaki Uchimoto <[email protected]> * Resolve PoA dependencies (#8584) * ♻️ Resolve dependencies and add configurable constant * ♻️ Use authorityRegistrationFee in endpoint and fix test * Add PoAMethod to src/index.ts * Use PoA dependency * Move setValidatorsParams to under registerValidatorKeys (#8672) Co-authored-by: !shan <[email protected]> * Expose PoA Commands (#8699) Expose Commands on PoA * PoA Example (And update to application.ts) (#8663) * Add PoA example * Update PoA Genesis * Update README and remove uncessary genesis json * Update application.ts to accept PoS and PoA * Add Reward Module to PoA * Renaming poa to sidechain * Revert application.ts * Move setValidatorsParams to under registerValidatorKeys * Register module inside the PoA * Add RewardModule and revert module.ts (Changes in separate PR) * Add sign scripts for updateAuthority.ts * Update yarn.lock * Fix `registerValidatorKeys` (#8703) Co-authored-by: !shan <[email protected]> * Fix `poa_getAllValidators` endpoint (#8700) * Update getAllValidators Endpoint * Update test cases for poa_getAllValidators * Sort response by name on getAllValidators function * Update PoA test cases * Update code per PR comments --------- Co-authored-by: Khalid Hameed <[email protected]> * ♻️ Update interfaces used in PoA * ✅ Fix test and lint error --------- Co-authored-by: Franco NG <[email protected]> Co-authored-by: sitetester <[email protected]> Co-authored-by: Mitsuaki Uchimoto <[email protected]> Co-authored-by: Mitsuaki Uchimoto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8414
How was it solved?
Implemented RegisterAuthorityCommand
How was it tested?
Unit Test added