Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix message recovery logic and tests #8778

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

mitsuaki-u
Copy link
Contributor

What was the problem?

This PR resolves #8613 #8774

How was it solved?

  • Fixed unnecessary prehashing before verifying data block
  • Update applyRecovery and forwardRecovery to return updated CCM object
  • Fixed invalid tests and remove mocking of merkletree.verifyDataBlock to maintain test integrity

How was it tested?

Added and updated relevant tests

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8778 (d921c99) into release/6.0.0 (d921c99) will not change coverage.
The diff coverage is n/a.

❗ Current head d921c99 differs from pull request most recent head 8fbf4b2. Consider uploading reports for the commit 8fbf4b2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8778   +/-   ##
==============================================
  Coverage          83.33%   83.33%           
==============================================
  Files                594      594           
  Lines              22334    22334           
  Branches            3293     3293           
==============================================
  Hits               18612    18612           
  Misses              3722     3722           

@mitsuaki-u mitsuaki-u requested review from ricott1 and removed request for AndreasKendziorra July 27, 2023 13:55
@shuse2 shuse2 enabled auto-merge (squash) August 2, 2023 14:17
@shuse2 shuse2 merged commit d13e886 into release/6.0.0 Aug 2, 2023
10 checks passed
@shuse2 shuse2 deleted the 8613-recovery-replay branch August 2, 2023 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants