Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

CCU creation fails sometimes when the node fails to save data on start of node #8315

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Mar 28, 2023

What was the problem?

This PR resolves #8288 #8312

How was it solved?

How was it tested?

Run interop examples with Chain connector plugin and see if they are able to successfully send the CCU transaction to each other

@ishantiw ishantiw self-assigned this Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #8315 (41f97ef) into development (ed8e947) will increase coverage by 0.01%.
The diff coverage is 92.30%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8315      +/-   ##
===============================================
+ Coverage        83.15%   83.17%   +0.01%     
===============================================
  Files              590      591       +1     
  Lines            21951    21958       +7     
  Branches          3213     3216       +3     
===============================================
+ Hits             18253    18263      +10     
+ Misses            3698     3695       -3     
Impacted Files Coverage Δ
...rability/base_interoperability_internal_methods.ts 90.82% <ø> (ø)
...ain-connector-plugin/src/chain_connector_plugin.ts 83.76% <83.33%> (+1.23%) ⬆️
...-framework-chain-connector-plugin/src/constants.ts 100.00% <100.00%> (ø)
...sk-framework-chain-connector-plugin/src/schemas.ts 100.00% <100.00%> (ø)
...ork-chain-connector-plugin/test/utils/sampleCCU.ts 100.00% <100.00%> (ø)
framework/src/modules/pos/endpoint.ts 97.14% <100.00%> (ø)

Copy link
Contributor

@ricott1 ricott1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@Phanco
Copy link
Contributor

Phanco commented Mar 29, 2023

Apart from the comment stated above, other parts are okay :D

@ishantiw ishantiw requested a review from Phanco March 29, 2023 11:57
@ishantiw ishantiw merged commit ae2a447 into development Mar 29, 2023
@ishantiw ishantiw deleted the 8288-ccu-fails-node-syncs branch March 29, 2023 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants