This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
CCU creation fails sometimes when the node fails to save data on start of node #8315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8315 +/- ##
===============================================
+ Coverage 83.15% 83.17% +0.01%
===============================================
Files 590 591 +1
Lines 21951 21958 +7
Branches 3213 3216 +3
===============================================
+ Hits 18253 18263 +10
+ Misses 3698 3695 -3
|
ishantiw
force-pushed
the
8288-ccu-fails-node-syncs
branch
from
March 29, 2023 10:01
8a80413
to
491ed32
Compare
ishantiw
force-pushed
the
8288-ccu-fails-node-syncs
branch
from
March 29, 2023 10:03
491ed32
to
766cc30
Compare
ricott1
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Phanco
reviewed
Mar 29, 2023
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
Apart from the comment stated above, other parts are okay :D |
Phanco
approved these changes
Mar 29, 2023
mitsuaki-u
reviewed
Mar 29, 2023
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
mitsuaki-u
approved these changes
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8288 #8312
How was it solved?
How was it tested?
Run interop examples with Chain connector plugin and see if they are able to successfully send the CCU transaction to each other