🐛 Use certificateThreshold from state instead of params - Closes #8316

LiskArchive · Mar 29, 2023 · 766cc30 · 766cc30
1 parent 9eb646c
commit 766cc30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/framework/src/modules/interoperability/base_interoperability_internal_methods.ts b/framework/src/modules/interoperability/base_interoperability_internal_methods.ts
@@ -401,7 +401,7 @@ export abstract class BaseInteroperabilityInternalMethod extends BaseInternalMet
 
 		const verifySignature = verifyAggregateCertificateSignature(
 			chainValidators.activeValidators,
-			params.certificateThreshold,
+			chainValidators.certificateThreshold,
 			params.sendingChainID,
 			certificate,
 		);

diff --git a/framework/test/unit/modules/interoperability/internal_method.spec.ts b/framework/test/unit/modules/interoperability/internal_method.spec.ts
@@ -1146,14 +1146,16 @@ describe('Base interoperability internal method', () => {
 			},
 		};
 
+		const chainValidators = {
+			activeValidators,
+			certificateThreshold: BigInt(20),
+		};
+
 		beforeEach(async () => {
 			jest.spyOn(interopMod.events.get(InvalidCertificateSignatureEvent), 'add');
 			await interopMod.stores
 				.get(ChainValidatorsStore)
-				.set(methodContext, txParams.sendingChainID, {
-					activeValidators,
-					certificateThreshold: BigInt(20),
-				});
+				.set(methodContext, txParams.sendingChainID, chainValidators);
 		});
 
 		it('should reject if verifyWeightedAggSig fails', async () => {
@@ -1171,7 +1173,7 @@ describe('Base interoperability internal method', () => {
 				txParams.sendingChainID,
 				encodedUnsignedCertificate,
 				activeValidators.map(v => v.bftWeight),
-				txParams.certificateThreshold,
+				chainValidators.certificateThreshold,
 			);
 
 			expect(interopMod.events.get(InvalidCertificateSignatureEvent).add).toHaveBeenCalledTimes(1);