This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Update apply() and crossChainCommands based on LIP49 #8032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phanco
requested review from
ishantiw and
sitetester
and removed request for
ishantiw
January 19, 2023 14:57
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8032 +/- ##
===============================================
+ Coverage 82.55% 82.56% +0.01%
===============================================
Files 578 578
Lines 20970 20986 +16
Branches 3042 3047 +5
===============================================
+ Hits 17312 17328 +16
Misses 3658 3658
|
ishantiw
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment but overall LGTM
framework/src/modules/interoperability/base_cc_commands/registration.ts
Outdated
Show resolved
Hide resolved
ishantiw
approved these changes
Jan 20, 2023
sitetester
suggested changes
Jan 20, 2023
framework/src/modules/interoperability/base_cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/recover_message.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cc_commands/channel_terminated.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cc_commands/registration.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cc_commands/registration.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cc_commands/registration.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
force-pushed
the
8011-update-apply-method
branch
from
January 23, 2023 11:39
f53c04c
to
3f02d8f
Compare
sitetester
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8011 and resolves #8053
How was it solved?
Added check to
apply
Removed
isLive
fromChannel Terminated Message
Added
chainID
fromregistrationCCMParamsSchema
Updated
verify
andexecute
ofRegistration Message
How was it tested?
Unit testes updated accordingly