Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update apply() and crossChainCommands based on LIP49 #8032

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Jan 17, 2023

What was the problem?

This PR resolves #8011 and resolves #8053

How was it solved?

Added check to apply
Removed isLive from Channel Terminated Message
Added chainID from registrationCCMParamsSchema
Updated verify and execute of Registration Message

How was it tested?

Unit testes updated accordingly

@Phanco Phanco requested review from ishantiw and sitetester and removed request for ishantiw January 19, 2023 14:57
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8032 (3f02d8f) into development (723817d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8032      +/-   ##
===============================================
+ Coverage        82.55%   82.56%   +0.01%     
===============================================
  Files              578      578              
  Lines            20970    20986      +16     
  Branches          3042     3047       +5     
===============================================
+ Hits             17312    17328      +16     
  Misses            3658     3658              
Impacted Files Coverage Δ
...c/modules/interoperability/events/ccm_processed.ts 100.00% <ø> (ø)
...roperability/mainchain/commands/recover_message.ts 99.30% <ø> (ø)
...in/commands/submit_mainchain_cross_chain_update.ts 96.55% <ø> (ø)
framework/src/modules/interoperability/schemas.ts 100.00% <ø> (ø)
...erability/sidechain/commands/register_mainchain.ts 100.00% <ø> (ø)
...in/commands/submit_sidechain_cross_chain_update.ts 97.29% <ø> (ø)
...operability/base_cc_commands/channel_terminated.ts 80.00% <100.00%> (+10.00%) ⬆️
.../interoperability/base_cc_commands/registration.ts 92.15% <100.00%> (+1.24%) ⬆️
...nteroperability/base_cross_chain_update_command.ts 98.70% <100.00%> (+0.02%) ⬆️
framework/src/testing/create_contexts.ts 94.17% <100.00%> (+0.05%) ⬆️

@Phanco Phanco marked this pull request as ready for review January 19, 2023 15:20
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment but overall LGTM

@Phanco Phanco requested a review from ishantiw January 20, 2023 11:44
@shuse2 shuse2 enabled auto-merge (squash) January 23, 2023 13:53
@shuse2 shuse2 merged commit 9c558f2 into development Jan 23, 2023
@shuse2 shuse2 deleted the 8011-update-apply-method branch January 23, 2023 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants