Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update apply method and cross chain commands based on LIP0049 update #8011

Closed
Tracked by #7210
ishantiw opened this issue Jan 13, 2023 · 0 comments · Fixed by #8032
Closed
Tracked by #7210

Update apply method and cross chain commands based on LIP0049 update #8011

ishantiw opened this issue Jan 13, 2023 · 0 comments · Fixed by #8032
Assignees
@Phanco
Labels
framework/module/interoperability Interoperability module
Milestone
Sprint 87

Comments

@ishantiw
Copy link
Contributor

Description

  • Add check if chainAccount(ccm.sendingChainID) exists and ccu.params.sendingChainID != ccm.sendingChainID:``Cannot receive forwarded messages for a direct channel. before command.execute in apply function - Reference LIP0049:apply
  • Update Channel Terminated Message - Remove isLive usage
  • Update registrationCCMParamsSchema - Add chainID
  • Update Registration Message - update verify and execute methods.

Acceptance Criteria

  • Should pass all the unit tests

Additional Information
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Phanco Phanco

Labels
framework/module/interoperability Interoperability module
Projects
None yet
Milestone
Sprint 87
Development

Successfully merging a pull request may close this issue.

Update apply() and crossChainCommands based on LIP49 LiskArchive/lisk-sdk
3 participants
@ishantiw @Phanco @Madhulearn