This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add new auxiliary functions for CCU #7743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
7723-add_util_func
branch
from
b83af81
to
ade8b92
Compare
ishantiw
approved these changes
Nov 7, 2022
framework/test/unit/modules/interoperability/stores/chain_account.spec.ts
Outdated
Show resolved
Hide resolved
…unt.spec.ts Co-authored-by: !shan <[email protected]>
sitetester
suggested changes
Nov 8, 2022
framework/test/unit/modules/interoperability/stores/chain_account.spec.ts
Outdated
Show resolved
Hide resolved
| currentValidator.bftWeight = updatedValidator.bftWeight; | ||
| } else { | ||
| activeValidators.push(updatedValidator); | ||
| activeValidators.sort((v1, v2) => v1.blsKey.compare(v2.blsKey)); |
There was a problem hiding this comment.
activeValidators.sort((v1, v2) => v1.blsKey.compare(v2.blsKey));
doesn't need to be inside loop (not good for performance reasons), so it could be just before return activeValidators;
framework/test/unit/modules/interoperability/internal_method.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/internal_method.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/internal_method.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/stores/chain_account.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/stores/chain_account.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
approved these changes
Nov 9, 2022
framework/test/unit/modules/interoperability/stores/channel_data.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/stores/channel_data.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/internal_method.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
added a commit
that referenced
this pull request
Nov 14, 2022
### What was the problem? This PR resolves #7723 ### How was it solved? - Add auxiliary functions in stores and internal method to use them - Update `messageWitness` to `messageWitnessHashes` for inbox - Fix misusage of mock in unit tests ### How was it tested? Added unit tests for stores and internal method Co-authored-by: !shan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7723
How was it solved?
messageWitnesstomessageWitnessHashesfor inboxHow was it tested?
Added unit tests for stores and internal method