Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement auxiliary functions for CCU processing #7723

Closed
Tracked by #7211
ishantiw opened this issue Nov 1, 2022 · 0 comments
Closed
Tracked by #7211

Implement auxiliary functions for CCU processing #7723

ishantiw opened this issue Nov 1, 2022 · 0 comments
Assignees
Labels
framework/module/interoperability Interoperability module
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Nov 1, 2022

Description

Acceptance Criteria

  • Should have unit tests for these functions

Additional Information

@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Nov 1, 2022
@shuse2 shuse2 self-assigned this Nov 4, 2022
@shuse2 shuse2 modified the milestones: Sprint 81, Sprint 82 Nov 4, 2022
shuse2 added a commit that referenced this issue Nov 9, 2022
### What was the problem?

This PR resolves #7723 

### How was it solved?

- Add auxiliary functions in stores and internal method to use them
- Update `messageWitness` to `messageWitnessHashes` for inbox
- Fix misusage of mock in unit tests

### How was it tested?

Added unit tests for stores and internal method

Co-authored-by: !shan <[email protected]>
@shuse2 shuse2 closed this as completed Nov 9, 2022
shuse2 added a commit that referenced this issue Nov 9, 2022
### What was the problem?

This PR resolves #7723 

### How was it solved?

- Create BaseCrossChainUpdateCommand
- Move apply/bounce to BaseCrossChainUpdateCommand
- Update cc_update for mainchain/sidechain to extend from
BaseCrossChainUpdateCommand
- Update Context to include `stateStore` for snapshot

### How was it tested?

- Update all unit tests
ishantiw added a commit that referenced this issue Nov 14, 2022
### What was the problem?

This PR resolves #7723 

### How was it solved?

- Add auxiliary functions in stores and internal method to use them
- Update `messageWitness` to `messageWitnessHashes` for inbox
- Fix misusage of mock in unit tests

### How was it tested?

Added unit tests for stores and internal method

Co-authored-by: !shan <[email protected]>
ishantiw pushed a commit that referenced this issue Nov 14, 2022
This PR resolves #7723

- Create BaseCrossChainUpdateCommand
- Move apply/bounce to BaseCrossChainUpdateCommand
- Update cc_update for mainchain/sidechain to extend from
BaseCrossChainUpdateCommand
- Update Context to include `stateStore` for snapshot

- Update all unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework/module/interoperability Interoperability module
Projects
None yet
Development

No branches or pull requests

2 participants