-
Notifications
You must be signed in to change notification settings - Fork 454
Update Channel Terminated Message cross chain command #7696
Update Channel Terminated Message cross chain command #7696
Conversation
…HQ/lisk-sdk into 7656-update-channel-terminated-message
…HQ/lisk-sdk into 7656-update-channel-terminated-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its better to rename, base_classes
or common
to be more precise and also move other base classes within it that are present within interoperability
folder?
framework/src/modules/interoperability/base/cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
Since those classes starts with |
@ishantiw that involves quite a number of file changes if I move |
8fb4506
to
69a8bc9
Compare
@Phanco lets refactor this later in another issue, Meanwhile use |
778b13f
to
44ece03
Compare
44ece03
to
89e571b
Compare
@ishantiw Tests are mostly copy paste in framework/test/unit/modules/interoperability/mainchain/cc_commands/channel_terminated.spec.ts & framework/test/unit/modules/interoperability/mainchain/cc_commands/channel_terminated.spec.ts We can use same approach as was taken previously in case of |
framework/test/unit/modules/interoperability/sidechain/cc_commands/channel_terminated.spec.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cc_commands/channel_terminated.ts
Outdated
Show resolved
Hide resolved
…HQ/lisk-sdk into 7656-update-channel-terminated-message
cbe70d1
to
f13b31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phanco lgtm, maybe we can move test to one common file as @sitetester suggests. You can follow similar approach as we have in #7700
…HQ/lisk-sdk into 7656-update-channel-terminated-message
Took reference on #7700 and updated test case, thanks :D |
…HQ/lisk-sdk into 7656-update-channel-terminated-message
What was the problem?
This PR resolves #7656
How was it solved?
Created a new
BaseCCChannelTerminatedCommand
insidebase/cc_commands
How was it tested?
Unit Test Updated accordingly