Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update Channel Terminated Message cross chain command #7656

Closed
Tracked by #7211
ishantiw opened this issue Oct 18, 2022 · 0 comments · Fixed by #7696
Closed
Tracked by #7211

Update Channel Terminated Message cross chain command #7656

ishantiw opened this issue Oct 18, 2022 · 0 comments · Fixed by #7696
Assignees
@Phanco
Labels
framework/module/interoperability Interoperability module
Milestone
Sprint 81

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Oct 18, 2022 •
edited
Loading

Description

  • Update command schema
channelTerminatedCCMParamsSchema = {
    "type": "object",
    "required": ["stateRoot", "inboxSize"],
    "properties": {
        "stateRoot": {
            "dataType": "bytes",
            "length": HASH_LENGTH,
            "fieldNumber": 1
        },
        "inboxSize": {
            "dataType": "uint32",
            "fieldNumber": 2
        }
    }
}
  • Update execute method
def execute(ccu: Transaction, ccm: CCM) -> None:
    if isLive(ccm.sendingChainID):
        createTerminatedStateAccount(ccm.sendingChainID)

Acceptance Criteria

  • Should have all the unit tests

Additional Information
@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Oct 18, 2022
@ishantiw ishantiw mentioned this issue Oct 18, 2022
Closed
71 tasks
@shuse2 shuse2 added this to the Sprint 81 milestone Oct 24, 2022
@Phanco Phanco self-assigned this Oct 25, 2022
@ishantiw ishantiw linked a pull request Oct 26, 2022 that will close this issue
Update Channel Terminated Message cross chain command #7696
Merged
@Phanco Phanco mentioned this issue Oct 26, 2022
Merged
ishantiw added a commit that referenced this issue Nov 7, 2022
@ishantiw
Update Channel Terminated Message cross chain command (#7696)
1cf249d 
### What was the problem?

This PR resolves #7656

### How was it solved?

Created a new `BaseCCChannelTerminatedCommand` inside `base/cc_commands`

### How was it tested?

Unit Test Updated accordingly
@ishantiw ishantiw closed this as completed Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Phanco Phanco

Labels
framework/module/interoperability Interoperability module
Projects
None yet
Milestone
Sprint 81
Development

Successfully merging a pull request may close this issue.

Update Channel Terminated Message cross chain command LiskArchive/lisk-sdk
3 participants
@shuse2 @ishantiw @Phanco