This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Update validateFormat for ccm - Closes #7599 #7655
Merged
ishantiw
merged 4 commits into
feature/7211-interop-module-updates
from
7599-update-validate-format-for-ccm
Oct 24, 2022
Merged
Update validateFormat for ccm - Closes #7599 #7655
ishantiw
merged 4 commits into
feature/7211-interop-module-updates
from
7599-update-validate-format-for-ccm
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phanco
changed the base branch from
development
to
feature/7211-interop-module-updates
October 18, 2022 16:01
ishantiw
suggested changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, a few comments
sitetester
suggested changes
Oct 19, 2022
Phanco
force-pushed
the
7599-update-validate-format-for-ccm
branch
from
October 20, 2022 11:25
d9a7351
to
5ea8fb8
Compare
ishantiw
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
sitetester
suggested changes
Oct 21, 2022
sitetester
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7599
How was it solved?
Updated
validateFormat
according to requirementUpdated
ccmSchema
according to requirementHow was it tested?
Updated unit-test