Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update validateFormat for ccm - Closes #7599 #7655

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Oct 18, 2022

What was the problem?

This PR resolves #7599

How was it solved?

Updated validateFormat according to requirement
Updated ccmSchema according to requirement

How was it tested?

Updated unit-test

@Phanco Phanco changed the base branch from development to feature/7211-interop-module-updates October 18, 2022 16:01
@ishantiw ishantiw linked an issue Oct 18, 2022 that may be closed by this pull request
@Phanco Phanco marked this pull request as ready for review October 19, 2022 10:00
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few comments

framework/src/modules/interoperability/schemas.ts Outdated Show resolved Hide resolved
framework/src/modules/interoperability/utils.ts Outdated Show resolved Hide resolved
@Phanco Phanco force-pushed the 7599-update-validate-format-for-ccm branch from d9a7351 to 5ea8fb8 Compare October 20, 2022 11:25
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ishantiw ishantiw merged commit 9fe50f9 into feature/7211-interop-module-updates Oct 24, 2022
@ishantiw ishantiw deleted the 7599-update-validate-format-for-ccm branch October 24, 2022 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update validateFormat for ccm
3 participants